Feature #2586 GenVxMask improvements

[georgemccabe]

Change Summary

• Add function to properly parse gen_vx_mask command line options to handle options that support multiple items separated by comma within a given option, e.g. -type lat,lon. See commit 191d858
• Enhanced GenVxMask wrapper to be find input files consistent with other wrappers (part of Enhancement: Refactor wrappers to consistently find input files #2492)
• Added support for setting file window range separately for input files and mask files
• Other code cleanup to appease SonarQube and move towards consistent wrappers with fewer wrapper-specific overrides of common functions, e.g. get_command.

Pull Request Testing

• Describe testing already performed for these changes:
  

• Added new unit tests for new gen_vx_mask command line option format that are newly supported with Feature #2966 local_solar_time MET#3008
• Ensured all existing tests still pass

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

Review code changes and ensure all tests pass (note land_surface:0 will likely report diffs that are unrelated to the changes in this PR)

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

• Do these changes include sufficient testing updates? [Yes]

• Will this PR result in changes to the test suite? [No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Do these changes introduce new SonarQube findings? [No]
  
  If yes, please describe:

It should reduce them!

• Please complete this pull request review by 12/20/2024.
  

Pull Request Checklist

See the METplus Workflow for details.

• Add any new Python packages to the METplus Components Python Requirements table.
• For any new datasets, an entry to the METplus Verification Datasets Guide.
• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s) and Development issue
  Select: Milestone as the version that will include these changes
  Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases
• After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[JohnHalleyGotway]

I see that all the tests passed for this PR, including the newly added ones, which is great. So there's no issues with the logic. And I looked through the code changes themselves and don't see any obvious issues.

However, I would recommend modifying the naming conventions for the newly added METplus config options. You added options for GEN_VX_MASK_OBS_FILE... and GEN_VX_MASK_MASK_FILE... to correspond to the setting of gen_vx_mask -input and -mask command line options.

For consistency and clarity, I'd recommend renaming the GEN_VX_MASK_OBS_FILE... options as GEN_VX_MASK_INPUT_FILE... throughout since they control the values for the -input command line option. In the context of gen_vx_mask, there's no distinguishing between forecast and observation. It just process generic data that could come from any source.

[JohnHalleyGotway]

I approve of these changes.

@georgemccabe I see that you made the switch from GEN_VX_MASK_OBS_FILE... config options to GEN_VX_MASK_INPUT_FILE... and that all the tests have passed.

Thanks!