Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #2821 prepare v6.0.0 release #2843

Merged
merged 10 commits into from
Dec 19, 2024
Merged

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented Dec 18, 2024

@georgemccabe georgemccabe added this to the METplus-6.0.0 milestone Dec 18, 2024
@georgemccabe georgemccabe linked an issue Dec 18, 2024 that may be closed by this pull request
@georgemccabe georgemccabe marked this pull request as ready for review December 18, 2024 21:43
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend moving a few items from the "Internal" section to the "Documentation" section. I'd also recommend renaming "Internal" as "Repository, build, and test" for consistency with the section in the MET release notes and to provide a little more description of those issue types.

The other release notes look fine and are basically just the titles of the source issues. In general, I'd seek more consistency in issue title naming conventions to make them more easily digestible and understood.

I like it when...

  • Bugfix titles are "Fix ABC to do XYZ".
  • Enhancement titles are "Enhance ABC to do XYZ" (or "Add ABC to XYZ")
  • And so on.

With lots of people writing lots of titles, we're going to get lots of variations in the conventions. I think the process of drafting the release notes is to seek more standardization and consisency.

Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @georgemccabe. Thanks for making these updates.

I approve.

@georgemccabe georgemccabe merged commit b58a329 into main_v6.0 Dec 19, 2024
68 checks passed
@georgemccabe georgemccabe deleted the feature_2821_v6.0.0 branch December 19, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Create the METplus v6.0.0 release
2 participants