Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow logger and loggerInstance #497

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Jan 2, 2025

In this PR:

  • Bug fix (non-breaking change which fixes an issue)

Issues reference:

I haven't reported an issue yet, because I just found out about the issue, and figured it'd be better to just fix it than to report an issue first.

You cannot provide both logger and loggerInstance. Please provide only one.'

this happens when passing:

const fileLogger = pino(pino.destination(turboLogsPath));

const fastifyApp = createApp({
  logger: fileLogger,
});

Noticed with an accidental upgrade to 2.2.8 (from 2.2.1), which includes the loggerInstance change from 2.2.7, here:

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you lint your code with pnpm lint locally prior to submission?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran build with pnpm build of your changes locally?
  • Have you successfully ran tests with pnpm test of your changes locally?
  • Have you commit using Conventional Commits?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant