Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update platform.local.txt to use python2 alias #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kevinjohna6
Copy link

@Vincent-Stragier
Copy link

Hello Kevin,

I don't know if it is useful to keep the Python 2 compatibility. I did try to bring the Python 3 compatibility one or two years ago, but it was far for being ideal (breaking stuff, etc.).

I try to insure the Python 3 compatibility for the moment, but I did not test my code on other platforms, etc.

I did use hints in the code and it makes it incompatible with Python 2. Also the use print(), write() are often the main source of error (byte arrays instead of string, etc.).

Also, I've seen that there is a binutils for the esp32s2... so it's not yet in the recipe.

@kevinjohna6 and @duff2013, my code 'reformatting' is in this zip, if you want to take a look 😄
src.zip

The main changes are speed improvements (faster list and dict declarations, the function calls costing more operations) and full compliance with the PEP8 directives.

Have a nice day,

Vincent

@duff2013
Copy link
Owner

I'm planning to drop python 2 support in the future but until then I want it compatible. Maybe this is the solution for now I'll take a look at this sometime soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants