Add build hook to copy .s files
#90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
Previously, the project relied on undefined behavior of older versions of the Arduino build system, where correct file extension case was not enforced when copying files from the sketch folder to the build folder, in order to . This stopped working at Arduino IDE 1.8.14, meaning that users were forced to use a significantly outdated version of the IDE; a requirement which was undocumented. This is fixed by adding an additional build hook to platform.local.txt that copies the `.s` files from the sketch folder to the build folder. Due to limitations of the Arduino platform framework, it was necessary to jump through some hoops to get working patterns for these commands: - Windows command pattern must use `cmd /C` because `copy` is not directly usable via the os/exec Go package that executes the generated commands. - Linux/macOS command patterns must use `cd` because otherwise the `*.s` glob was broken by being automatically quoted as part of the sketch path. - Linux/macOS command patters must use `sh -c` because `cd` is not directly usable via the os/exec Go package that executes the generated commands.
per1234
force-pushed
the
add-file-copy-hook
branch
from
190aa9f to
6bc4ccb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the project relied on undefined behavior of older versions of the Arduino build system, where correct file extension case was not enforced when copying files from the sketch folder to the build folder, in order to .
This stopped working at Arduino IDE 1.8.14, meaning that users were forced to use a significantly outdated version of the IDE; a requirement which was undocumented.
This is fixed by adding an additional build hook to
platform.local.txtthat copies the.sfiles from the sketch folder to the build folder.Due to limitations of the Arduino platform framework, it was necessary to jump through some hoops to get working patterns for these commands:
cmd /Cbecausecopyis not directly usable via theos/execGo package that executes the generated commands.cdbecause otherwise the*.sglob was broken by being automatically quoted as part of the sketch path.sh -cbecausecdis not directly usable via theos/execGo package that executes the generated commands.Fixes #74