DUPLO-26089: use a predetermined localPort #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
duplodavid
approved these changes
Oct 31, 2024
duplodavid
added a commit
that referenced
this pull request
Nov 8, 2024
* version bump * add codium AI pr agent * update codium AI pr agent * DUPLO-13650 improve format of tenant missing message * DUPLO-13650 elide err when nil in fatal messages * Update CHANGELOG.md * DUPLO docs: add Homebrew installation section * Update CHANGELOG.md * DUPLO-26089: use a predetermined localPort (#29) * Allowing to choose port in interactive auth * Fixing port usage --------- Co-authored-by: notofir <[email protected]> * DUPLO-26089 Update versions in workflows * DUPLO-26089 update go.mod to 1.23 * DUPLO-26089 fix a few lint issues * DUPLO-26089 fix two more lint issues --------- Co-authored-by: duplo-bot <[email protected]> Co-authored-by: Joe Khoobyar <[email protected]> Co-authored-by: David Wolfe <[email protected]> Co-authored-by: codiumai-pr-agent-pro[bot] <151058649+codiumai-pr-agent-pro[bot]@users.noreply.github.com> Co-authored-by: Joe Khoobyar <[email protected]> Co-authored-by: Matheus Bafutto <[email protected]> Co-authored-by: Zafar Abbas <[email protected]> Co-authored-by: notofir <[email protected]> Co-authored-by: sp1676 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Proposed by Ofir @ Seven AI
duplo-jitto have it use a predetermined localPort, which could then be exposed from devcontainerSlack:
question for the duplo folks about duplo-jit + aws + admin access
specifically, this part of the ~/.aws/config file:
some of our team is working within a visual studio devcontainer , so when duplo-jit sends us out to the browser to click "Authorize" , the authorize button won't work because the localPort isn't exposed from our devcontainer
example url: https://duplo.cloud.sevenai.com/app/user/verify-token?localAppName=duplo-jit&localPort=45461&isAdmin=true
what is the recommended solution ? I believe Ofir was hacking around on duplo-jit to have it use a predetermined localPort, which could then be exposed from devcontainer, in case that helps