fix: replace usage of outdated ifconfig with ip
#129
Conversation
There was a problem hiding this comment.
Thanks again @BoboTiG!
LGTM. I think we can remove some of the check_installed calls with this change.
I would like @herr-seppia his input though, since he wanted to keep some of the changes in here before.
|
Yes, I guess we can remove |
| @@ -12,43 +12,25 @@ if [[ -z "$PUBLIC_IP" || ! "$PUBLIC_IP" =~ ^[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+$ ]]; | |||
| exit 1 | |||
| fi | |||
|
|
|||
| runOnMac=false | |||
There was a problem hiding this comment.
I don't like the fact that MacOS support was removed, but indeed it's out of node-installer scope
There was a problem hiding this comment.
I don't like the fact that MacOS support was removed, but indeed it's out of node-installer scope
There's a couple of pathways we can take. The easiest is to implement #27 if we use MacOS with the installer for dev purposes. Or we try to actually broaden support once everything is more "stable" in the future.
Fixes #41.
int2ip(), andip2int(), are cosmetic only.