Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sender encryption to the Note #215

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Add sender encryption to the Note #215

merged 2 commits into from
Jun 17, 2024

Conversation

moCello
Copy link
Member

@moCello moCello commented Jun 14, 2024

Resolves #214

@moCello moCello force-pushed the mocello/214_sender_enc branch 2 times, most recently from 5caa5fa to ea4cf03 Compare June 17, 2024 12:51
@moCello moCello force-pushed the mocello/214_sender_enc branch from ea4cf03 to 889cd06 Compare June 17, 2024 13:10
ureeves
ureeves approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@ureeves ureeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some nitty comments

circuits/CHANGELOG.md Outdated Show resolved Hide resolved
circuits/src/transaction.rs Outdated Show resolved Hide resolved
circuits/tests/transaction.rs Outdated Show resolved Hide resolved
circuits/tests/transaction.rs Outdated Show resolved Hide resolved
xevisalle
xevisalle requested changes Jun 17, 2024
View reviewed changes
Copy link
Member

@xevisalle xevisalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing with @marta-belles , and after seeing the overall code, we think it makes more sense to call the recipient module / gadget / whatever, sender.

circuits/src/recipient.rs Outdated Show resolved Hide resolved
marta-belles
marta-belles reviewed Jun 17, 2024
View reviewed changes
circuits/src/transaction.rs Outdated Show resolved Hide resolved
circuits/src/transaction.rs Show resolved Hide resolved
circuits/src/transaction.rs Show resolved Hide resolved
circuits/tests/elgamal.rs Show resolved Hide resolved
circuits/tests/transaction.rs Outdated Show resolved Hide resolved
core/src/transaction.rs Outdated Show resolved Hide resolved
core/tests/encryption.rs Outdated Show resolved Hide resolved
xevisalle
xevisalle approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@xevisalle xevisalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moCello moCello force-pushed the mocello/214_sender_enc branch from a0da54d to cb76bb4 Compare June 17, 2024 16:08
@moCello moCello merged commit 6603447 into master Jun 17, 2024
6 checks passed
@moCello moCello deleted the mocello/214_sender_enc branch June 17, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marta-belles marta-belles marta-belles left review comments

@ureeves ureeves ureeves approved these changes

@xevisalle xevisalle xevisalle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add sender encryption to the Note
4 participants
@moCello @xevisalle @ureeves @marta-belles