Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rusk: HTTP - add endpoint for query account status #3423

Merged
merged 1 commit into from
Jan 25, 2025
Merged

rusk: HTTP - add endpoint for query account status #3423

merged 1 commit into from
Jan 25, 2025

Conversation

herr-seppia
Copy link
Member

@herr-seppia herr-seppia commented Jan 24, 2025 •
edited
Loading

Resolves #3422

@herr-seppia herr-seppia force-pushed the deprecated-legacy-http branch from 313ff04 to e818f0c Compare January 24, 2025 16:37
@herr-seppia herr-seppia force-pushed the deprecated-legacy-http branch from e818f0c to af271dd Compare January 24, 2025 16:41
@herr-seppia herr-seppia force-pushed the http-account branch 2 times, most recently from d3890a6 to 6bd023c Compare January 24, 2025 16:44
@herr-seppia herr-seppia linked an issue Jan 24, 2025 that may be closed by this pull request
Querying the balance of an address via the local node #3422
Closed
@herr-seppia herr-seppia changed the title rusk: HTTP - add endpoint for query moonlight address rusk: HTTP - add endpoint for query account status Jan 24, 2025
@herr-seppia herr-seppia changed the base branch from deprecated-legacy-http to master January 24, 2025 16:46
@herr-seppia herr-seppia changed the base branch from master to deprecated-legacy-http January 24, 2025 16:47
@herr-seppia herr-seppia marked this pull request as ready for review January 24, 2025 16:48
HDauven
HDauven previously approved these changes Jan 25, 2025
View reviewed changes
Copy link
Member

@HDauven HDauven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@herr-seppia herr-seppia changed the base branch from deprecated-legacy-http to master January 25, 2025 09:49
@herr-seppia herr-seppia dismissed HDauven’s stale review January 25, 2025 09:49

The base branch was changed.

@herr-seppia herr-seppia requested a review from HDauven January 25, 2025 09:49
@herr-seppia
Copy link
Member Author

LGTM

I changed the PR to not require #3421
This way, we can release it faster
@HDauven can you re-review it?

@HDauven
Copy link
Member

HDauven commented Jan 25, 2025

LGTM

I changed the PR to not require #3421 This way, we can release it faster @HDauven can you re-review it?

I was about to review that one today. Only thing we need to keep in mind is that the explorer still relies on it. So we should coordinate the roll out of that change with @kieranhall. Webtech does want to work on it already though.

@herr-seppia
Copy link
Member Author

Yes you're right
I think moving the explorer the rues polling would be pretty straightforward (no change in logic at all)

@herr-seppia herr-seppia merged commit 944cdc5 into master Jan 25, 2025
16 checks passed
@herr-seppia herr-seppia deleted the http-account branch January 25, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HDauven HDauven HDauven approved these changes

@moCello moCello Awaiting requested review from moCello

@Neotamandua Neotamandua Awaiting requested review from Neotamandua

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Querying the balance of an address via the local node
2 participants
@herr-seppia @HDauven