Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some typos in comment #1713

Merged
merged 1 commit into from
Jan 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/keepers/keepers.go
Original file line number Diff line number Diff line change
Expand Up @@ -661,7 +661,7 @@ func (a *AppKeepers) GetStakingKeeper() ibctestingtypes.StakingKeeper {
func initParamsKeeper(appCodec codec.BinaryCodec, legacyAmino *codec.LegacyAmino, key, tkey storetypes.StoreKey) paramskeeper.Keeper {
paramsKeeper := paramskeeper.NewKeeper(appCodec, legacyAmino, key, tkey)

// deprecated subspaces. loaded manually as the keeper doens't load it
// deprecated subspaces. loaded manually as the keeper doesn't load it
paramsKeeper.Subspace(authtypes.ModuleName).WithKeyTable(authtypes.ParamKeyTable())
paramsKeeper.Subspace(banktypes.ModuleName).WithKeyTable(banktypes.ParamKeyTable())
paramsKeeper.Subspace(stakingtypes.ModuleName).WithKeyTable(stakingtypes.ParamKeyTable())
Expand Down
2 changes: 1 addition & 1 deletion ibctesting/light_client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ func (s *lightClientSuite) TestMsgUpdateClient_StateUpdateExists_Compatible() {
_, err = s.path.EndpointA.Chain.SendMsgs(msg)
s.NoError(err)
s.Equal(uint64(header.Header.Height), s.path.EndpointA.GetClientState().GetLatestHeight().GetRevisionHeight())
// There shouldnt be any optimistic updates as the roots were verified
// There shouldn't be any optimistic updates as the roots were verified
_, err = s.hubApp().LightClientKeeper.GetSigner(s.hubCtx(), s.path.EndpointA.ClientID, uint64(header.Header.Height))
s.Error(err)
}
Expand Down
8 changes: 4 additions & 4 deletions x/incentives/keeper/msg_server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -387,23 +387,23 @@ func (suite *KeeperTestSuite) TestChargeFeeIfSufficientFeeDenomBalance() {

expectError bool
}{
"fee + base denom gauge coin == acount balance, success": {
"fee + base denom gauge coin == account balance, success": {
accountBalanceToFund: sdk.NewCoin("adym", sdk.NewInt(baseFee)),
feeToCharge: baseFee / 2,
gaugeCoins: sdk.NewCoins(sdk.NewCoin("adym", sdk.NewInt(baseFee/2))),
},
"fee + base denom gauge coin < acount balance, success": {
"fee + base denom gauge coin < account balance, success": {
accountBalanceToFund: sdk.NewCoin("adym", sdk.NewInt(baseFee)),
feeToCharge: baseFee/2 - 1,
gaugeCoins: sdk.NewCoins(sdk.NewCoin("adym", sdk.NewInt(baseFee/2))),
},
"fee + base denom gauge coin > acount balance, error": {
"fee + base denom gauge coin > account balance, error": {
accountBalanceToFund: sdk.NewCoin("adym", sdk.NewInt(baseFee)),
feeToCharge: baseFee/2 + 1,
gaugeCoins: sdk.NewCoins(sdk.NewCoin("adym", sdk.NewInt(baseFee/2))),
expectError: true,
},
"fee + base denom gauge coin < acount balance, custom values, success": {
"fee + base denom gauge coin < account balance, custom values, success": {
accountBalanceToFund: sdk.NewCoin("adym", sdk.NewInt(11793193112)),
feeToCharge: 55,
gaugeCoins: sdk.NewCoins(sdk.NewCoin("adym", sdk.NewInt(328812))),
Expand Down
2 changes: 1 addition & 1 deletion x/lockup/client/cli/query.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ func GetCmdModuleLockedAmount() (*osmocli.QueryDescriptor, *types.ModuleLockedAm
}, &types.ModuleLockedAmountRequest{}
}

// GetCmdAccountUnlockableCoins returns unlockable coins which has finsihed unlocking.
// GetCmdAccountUnlockableCoins returns unlockable coins which has finished unlocking.
// TODO: DELETE THIS + Actual query in subsequent PR
func GetCmdAccountUnlockableCoins() *cobra.Command {
cmd := &cobra.Command{
Expand Down
2 changes: 1 addition & 1 deletion x/lockup/keeper/lock.go
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ func (k Keeper) InitializeAllLocks(ctx sdk.Context, locks []types.PeriodLock) er
return err
}

// Add to the accumlation store cache
// Add to the accumulation store cache
for _, coin := range lock.Coins {
// update or create the new map from duration -> Int for this denom.
var curDurationMap map[time.Duration]sdk.Int
Expand Down
2 changes: 1 addition & 1 deletion x/sequencer/keeper/get_and_set.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func (k Keeper) SetSequencer(ctx sdk.Context, seq types.Sequencer) {

// SetSequencerByDymintAddr : allows reverse lookup of sequencer by dymint address
func (k Keeper) SetSequencerByDymintAddr(ctx sdk.Context, dymint cryptotypes.Address, addr string) error {
// could move this inside SetSequencer but it would require propogating error up a lot
// could move this inside SetSequencer but it would require propagating error up a lot
return k.dymintProposerAddrToAccAddr.Set(ctx, dymint, addr)
}

Expand Down
2 changes: 1 addition & 1 deletion x/sponsorship/types/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ func (g GaugeWeight) Validate() error {
return nil
}

// ToDistribution multiplies each gauge weight by the voting power to get its absolut voting power.
// ToDistribution multiplies each gauge weight by the voting power to get its absolute voting power.
func (v Vote) ToDistribution() Distribution {
return ApplyWeights(v.VotingPower, v.Weights)
}
Expand Down
Loading