Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raise errors when improper use #47

Merged
merged 1 commit into from
Aug 22, 2024
Merged

raise errors when improper use #47

merged 1 commit into from
Aug 22, 2024

Conversation

devkral
Copy link
Contributor

@devkral devkral commented Aug 22, 2024

Changes:

  • set the engine to None after disconnect. This prevents an incorrect reuse.
  • raise RuntimeError when db is not connected but connections are created.

@devkral
Changes:
d22597f 
- set the engine to None after disconnect. This prevents an incorrect
reuse.
- raise RuntimeError when db is not connected but connections are
  created.
@devkral devkral merged commit 7384190 into main Aug 22, 2024
10 checks passed
@devkral devkral deleted the devkral/fix/remove_engine_after_disconnect branch August 22, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarsil tarsil tarsil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devkral @tarsil