Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite plugin using http client mixin #28

Merged
merged 20 commits into from
Jul 13, 2023
Merged

Rewrite plugin using http client mixin #28

merged 20 commits into from
Jul 13, 2023

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Jul 7, 2023

@dyladan
Copy link
Member Author

dyladan commented Jul 7, 2023

Looks like the ssl_verification_mode option for logstash-mixin-http_client was only introduced in 7.1.0, which means that the option will have no effect in any version of logstash which provides a lower version of the mixin than that. It looks like that means the option will only work in logstash >= 8.1.0. In previous versions, the SSL verification cannot be turned off. 8.1.0 was released just over a year ago.

I suggest that we move forward with this change, but document that in order to use the ssl_verify_none option with a version of logstash older than 8.1.0, version 0.3.2 of this plugin must be used.

@dyladan dyladan marked this pull request as ready for review July 10, 2023 14:25
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/index.asciidoc Outdated Show resolved Hide resolved
lib/logstash/outputs/dynatrace.rb Outdated Show resolved Hide resolved
lib/logstash/outputs/dynatrace.rb Show resolved Hide resolved
spec/spec_helper.rb Outdated Show resolved Hide resolved
spec/spec_helper.rb Show resolved Hide resolved
spec/spec_helper.rb Outdated Show resolved Hide resolved
spec/spec_helper.rb Show resolved Hide resolved
lib/logstash/outputs/dynatrace.rb Show resolved Hide resolved
lib/dynatrace/version.rb Show resolved Hide resolved
@pirgeo
Copy link
Member

pirgeo commented Jul 12, 2023

Putting my approval here mainly for the wording parts, I do not have enough Ruby experience to review this thoroughly.

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Tested it locally and works as expected 🙂

version.yaml Outdated Show resolved Hide resolved
Co-authored-by: Armin Ruech <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dyladan dyladan merged commit 03de864 into main Jul 13, 2023
@dyladan dyladan deleted the http-client-mixin branch July 13, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants