-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite plugin using http client mixin #28
Conversation
There are several TODOs in the code and the tests still need to be done
Looks like the I suggest that we move forward with this change, but document that in order to use the |
Co-authored-by: Armin Ruech <[email protected]>
Putting my approval here mainly for the wording parts, I do not have enough Ruby experience to review this thoroughly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. Tested it locally and works as expected 🙂
Co-authored-by: Armin Ruech <[email protected]>
Kudos, SonarCloud Quality Gate passed!
|
Parts of this rewrite come from https://github.com/logstash-plugins/logstash-output-http
Uses https://github.com/logstash-plugins/logstash-mixin-http_client