Add Unit Tests for Parsing AMDGPU Binary #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This repo is no longer useful since the tests were merged into Dyninst. I'm going to put it in read-only mode. |
|
Sorry, I just realized this has some useful discussion to be had. Huge thanks for making some tests for AMD GPUs. However, I don't want the Dyninst repo to be a place for collecting binary files. I think git LFS would work. Otherwise, we could possibly store them in a public folder in /p/paradyn. That would prevent us from testing non-distributable binaries, though. @kupsh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testcase for GFX940 is skipped for now because of
dyninst/dyninst#1885