Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(livestream): added logic to recover from fatal errors #49

Merged
merged 1 commit into from
Feb 3, 2025
Merged

fix(livestream): added logic to recover from fatal errors #49

merged 1 commit into from
Feb 3, 2025

Conversation

ravindra-dyte
Copy link
Contributor

Linear Issue
fixes WEB-4138

Description

  1. Added changes to handle fatal failures in livestream player.
  2. Added the functionality to auto hide the control for an immersive experience. Auto margin is pending. Will ship the fixes in next PR to handle UI gracefully rather than basing it on clientHeigh & clientWidth.

@ravindra-dyte ravindra-dyte requested a review from a team as a code owner January 15, 2025 07:11
roerohan
roerohan approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@roerohan roerohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roerohan roerohan merged commit f3a37d3 into staging Feb 3, 2025
5 checks passed
@roerohan roerohan deleted the fix/WEB-4138-livestream-player-robustness branch February 3, 2025 08:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025

🎉 This PR is included in version 2.2.0-staging.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025

🎉 This PR is included in version 2.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roerohan roerohan roerohan approved these changes

Assignees
No one assigned
Labels
released on @staging released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ravindra-dyte @roerohan