-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Refactor Mediatool, 2.0 backlog issues #1114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two minor comments. This looks much better than before, good job!
Thanks for the review! Quick question: Can I merge this (and the rest of the PRs), or do I need to bump the version? I'm not sure what the convention is for this. |
@mgardzinski yes you can merge without bumping. The release is done whenever you bump the version in |
d1a67bc
to
9bbbbe5
Compare
Summary
Prefect migration 2.0 backlog changes for Mediatool, related to issues:
Mediatool._rename_columns()
#1062Mediatool
- move connector logic from Prefect task to the connector #1061Mediatool
- renamemethod
param toendpoint
#1060BigQuery
andMediatool
- removeapi_connection()
method #1049Importance
Fixing bug, clean code
Checklist
This PR:
CONTRIBUTING.md
CHANGELOG.md