Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactor Mediatool, 2.0 backlog issues #1114

Merged
merged 10 commits into from
Jan 13, 2025
Merged

Conversation

mgardzinski
Copy link

Summary

Prefect migration 2.0 backlog changes for Mediatool, related to issues:

Importance

Fixing bug, clean code

Checklist

This PR:

  • follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • adds/updates tests (if appropriate)
  • adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

@mgardzinski mgardzinski requested a review from trymzet January 3, 2025 15:28
Copy link
Contributor

@trymzet trymzet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two minor comments. This looks much better than before, good job!

src/viadot/sources/mediatool.py Outdated Show resolved Hide resolved
src/viadot/sources/mediatool.py Outdated Show resolved Hide resolved
@mgardzinski
Copy link
Author

Thanks for the review! Quick question: Can I merge this (and the rest of the PRs), or do I need to bump the version? I'm not sure what the convention is for this.

@mgardzinski mgardzinski requested a review from trymzet January 10, 2025 14:52
@trymzet
Copy link
Contributor

trymzet commented Jan 13, 2025

@mgardzinski yes you can merge without bumping. The release is done whenever you bump the version in pyproject.toml and merge that into 2.0, so eg. you can do the release as part of the last merged PR or as a separate PR.

@mgardzinski mgardzinski force-pushed the mediatool_backlog_issues branch from d1a67bc to 9bbbbe5 Compare January 13, 2025 12:14
@mgardzinski mgardzinski merged commit 2e4b37a into 2.0 Jan 13, 2025
3 checks passed
@mgardzinski mgardzinski deleted the mediatool_backlog_issues branch January 13, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants