Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(floating-ui): added support for floating-ui in dropdowns #2523

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Jan 14, 2025

Fixes #

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • In order to support floating ui, we needed to add some default styles. We have these as the default. I kept around the old behavior of the dropdown as menu-button__menu--set-position in case we need it (I do not think its necessary, but others might; menu buttons should only be toggled with javascript, so having a no-js option isn't really feasible).
  • For the width: I added it as fit-content. I also make sure it resizes appropriately. When I did max-content, there were some issues with overflowing menu items which would cause it to span across the whole page.

Screenshots

Screenshot 2025-01-14 at 8 11 42 AM Screenshot 2025-01-14 at 8 11 37 AM

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

Copy link

changeset-bot bot commented Jan 14, 2025

⚠️ No Changeset found

Latest commit: dc58664

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@agliga agliga merged commit 424839a into 19.0.0 Jan 14, 2025
@agliga agliga deleted the floatingui branch January 14, 2025 16:44
@agliga
Copy link
Contributor Author

agliga commented Jan 16, 2025

#2514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants