Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #20419: Fix TypeIdentifier comparation in TypeObject tests. #297

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
7ec537d
Support new fastdds naming (#315)
richiware Mar 11, 2024
f3a5fc3
Rename RTPS_DllAPI to FASTDDS_EXPORTED_API (#311)
EduPonz Mar 18, 2024
83aa359
Run Fast DDS Gen CI on PRs to 4.0.x-devel (#317)
EduPonz Mar 18, 2024
9f1e793
Update fastrtps migrated headers (#318)
elianalf Mar 25, 2024
6f257fd
New argument -genapi [19958] (#261)
richiware Nov 20, 2023
eeac300
Update IDL parser submodule to support new Union discriminator as a M…
JLBuenoLopez Nov 21, 2023
811e87a
Remove -cdr argument and support of Fast CDR v1 (#265)
richiware Nov 21, 2023
5ab6e31
User types header-only (#263)
richiware Nov 22, 2023
30105bb
Fix warning generating TypeObject from IDL file (#266)
richiware Nov 27, 2023
4168be8
Fix tests for common struct name in different modules (#268)
JLBuenoLopez Nov 28, 2023
dc7f76f
Add argument to change default unbounded countainer max size (#270)
richiware Nov 30, 2023
9d5a118
Fix CLang warning in generated code about unused lambda capture (#269)
JLBuenoLopez Dec 1, 2023
ca1e1e5
Support for C++ enum class (#271)
richiware Dec 1, 2023
8073a01
Use include header which will be used (#272)
richiware Dec 1, 2023
d8cd01c
Fix using final string for new annotations (#273)
richiware Dec 4, 2023
5d2a3c5
Add replacement for "dds" modules and -no-dependencies option to fast…
adriancampo Dec 12, 2023
e7ef32b
TypeObject generation (#280)
JLBuenoLopez Jan 29, 2024
8052dc2
Fix bounded collections with unbounded elements (#295)
JLBuenoLopez Feb 9, 2024
6487502
Test case: scoped structures (#299)
JLBuenoLopez Feb 13, 2024
cdf4c17
Update FastDDSGen tests for indirect hashes (#307)
adriancampo Mar 4, 2024
509b3d2
Support new fastdds naming (#315)
richiware Mar 11, 2024
061b090
Fix after rebase
richiware Mar 13, 2024
a2215d9
New implementation for unions (#310)
richiware Mar 15, 2024
81d2fcb
Fix TypeObjectPair API (#296)
JLBuenoLopez Apr 4, 2024
6f2d9be
Refs #20419: Fix TypeIdentifier comparation in TypeObject tests.
adriancampo Feb 12, 2024
ba7f9e9
Refs #20419: Fixes for unions
adriancampo Mar 25, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/fastddsgen.meta
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
{
"names":
{
"fastdds": {
"cmake-args": [
"-DEPROSIMA_BUILD_TESTS=ON"

]
},
"fastdds_python": {
"cmake-args": [
"-DBUILD_TESTING=ON"
Expand Down
10 changes: 1 addition & 9 deletions .github/workflows/reusable-ubuntu-ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -122,15 +122,7 @@ jobs:
cmake --version
colcon build --event-handlers=console_direct+ --mixin rel-with-deb-info ccache --metas src/fastddsgen/.github/fastddsgen.meta

- name: Test fastddsgen with fastcdr v1
if: startsWith(inputs.fastcdr_branch, '1')
run: |
source install/local_setup.bash
cd src/fastddsgen
./gradlew test -Dcdr_version=v1 -Dblacklist_tests=external,optional

- name: Test fastddsgen with fastcdr v2
if: ${{ ! startsWith(inputs.fastcdr_branch, '1') }}
- name: Test fastddsgen
run: |
source install/local_setup.bash
cd src/fastddsgen
Expand Down
13 changes: 6 additions & 7 deletions .github/workflows/ubuntu-ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ on:
description: 'foonathan_memory_vendor branch to be used'
required: true
type: string
fastcdr_version:
description: 'Fast CDR branches to be used. Enclose the branch names like ["1.1.x", "master"], then in single quotes'
fastcdr_branch:
description: 'Fast CDR branches to be used'
required: true
type: string
fastdds_branch:
Expand Down Expand Up @@ -40,15 +40,14 @@ jobs:
java_version:
- 'openjdk-11-jdk'
- 'openjdk-19-jdk'
fastcdr_version: ${{ fromJson(inputs.fastcdr_version || '["1.1.x", "master"]') }}

uses: ./.github/workflows/reusable-ubuntu-ci.yaml
with:
os_image: ${{ matrix.os_image }}
java_version: ${{ matrix.java_version }}
foonathan_memory_vendor_branch: ${{ inputs.foonathan_memory_vendor_branch || 'master' }}
fastcdr_branch: ${{ matrix.fastcdr_version }}
fastcdr_branch: ${{ inputs.fastcdr_branch || 'master' }}
fastdds_branch: ${{ inputs.fastdds_branch || github.head_ref }}
fastdds_python_branch: ${{ inputs.fastdds_python_branch || 'main' }}
fastddsgen_branch: ${{ inputs.fastddsgen_branch || github.ref || 'master' }}
fastdds_fallback_branch: ${{ 'master' }}
fastdds_python_branch: ${{ inputs.fastdds_python_branch || '3.0.x-devel' }}
fastddsgen_branch: ${{ inputs.fastddsgen_branch || github.ref || '4.0.x-devel' }}
fastdds_fallback_branch: ${{ '3.0.x-devel' }}
2 changes: 1 addition & 1 deletion colcon.pkg
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "fastddsgen",
"type": "gradle",
"test-dependencies" : ["fastrtps"]
"test-dependencies" : ["fastdds"]
}
2 changes: 1 addition & 1 deletion resources/Custom.stg
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ string_type(ctx, string) ::= <<>>

wide_string_type(ctx, wstring) ::= <<>>

array_declarator(ctx, array, array_type) ::= <<>>
array_declarator(ctx, array) ::= <<>>

interface(ctx, parent, interface, export_list) ::= <<>>

Expand Down
18 changes: 2 additions & 16 deletions src/main/java/com/eprosima/fastcdr/idl/context/Context.java
Original file line number Diff line number Diff line change
Expand Up @@ -39,27 +39,13 @@ public interface Context

public String getHeaderGuardName ();

public boolean isGenerateTypeObject();

public boolean isGenerateTypesC();

public boolean isGenerateTypesROS2();

public boolean isGenerateTypeObjectSupport();

public boolean isCdr();

public boolean isFastcdr();

public boolean isCdr_v1();

public boolean isCdr_v2();

public boolean isCdr_both();

public void isSetCdrv1Templates();

public void isUnsetCdrv1Templates();

public boolean isCdrv1TemplatesEnabled();

/*** End ***/
}
10 changes: 10 additions & 0 deletions src/main/java/com/eprosima/fastcdr/idl/templates/FastCdrCommon.stg
Original file line number Diff line number Diff line change
Expand Up @@ -59,3 +59,13 @@ member_array_cstring_destructor(ctx, name, loopvar, dims) ::= <<$if(rest(dims))$
{
free(str);
}$endif$>>

member_default_init(member) ::= <%
$if(member.annotationDefault)$
{$member.annotationDefaultValue$}
$elseif(!member.annotationOptional && !member.annotationExternal)$
$if(member.typecode.initialValue)$
{$member.typecode.initialValue$}
$endif$
$endif$
%>
6 changes: 3 additions & 3 deletions src/main/java/com/eprosima/fastcdr/idl/templates/JavaType.stg
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ public class $union.name$
}; separator="\n"$
}

public $union.discriminator.javaTypename$ getDiscriminator()
public $union.discriminator.typecode.javaTypename$ getDiscriminator()
{
return d__;
}
Expand All @@ -127,7 +127,7 @@ public class $union.name$
$endif$
}

public void set$member.javaName$($union.discriminator.javaTypename$ discriminator, $member.typecode.javaTypename$ $member.name$)
public void set$member.javaName$($union.discriminator.typecode.javaTypename$ discriminator, $member.typecode.javaTypename$ $member.name$)
throws Exception
{
$if(member.default)$
Expand Down Expand Up @@ -188,7 +188,7 @@ public class $union.name$
return false;
}

$union.discriminator.javaTypename$ d__;
$union.discriminator.typecode.javaTypename$ d__;

$union.members : { member |private $member.typecode.javaTypename$ $member.name$_; }; separator="\n"$

Expand Down
Loading
Loading