Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing python modules correctly [20800] #119

Merged
merged 6 commits into from
May 24, 2024
Merged

Conversation

richiware
Copy link
Member

@richiware richiware commented Apr 8, 2024

Description

This PR improves the installation of the python module, especially on windows.

  • Instead of install site-packages/fastdds.py, it install site-packages/fastdds/__init__.py. It's more python style.
  • The user doesn't have to import the C++ DLL file himself (win32api.LoadLibrary()). It is the python module who did it now.

Code generated with this PR:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Changes are API compatible.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware richiware changed the title Installing python modules correctly Installing python modules correctly [20800] Apr 15, 2024
Base automatically changed from 3.0.x-devel to main May 14, 2024 07:17
@richiware richiware force-pushed the feature/remove-win32api branch from 8d359b1 to 47077a8 Compare May 14, 2024 08:02
EduPonz
EduPonz previously approved these changes May 21, 2024
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with rebase and CI

richiware added 6 commits May 22, 2024 08:59
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
@EduPonz EduPonz merged commit 5dbeeaf into main May 24, 2024
4 checks passed
@EduPonz EduPonz deleted the feature/remove-win32api branch May 24, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants