Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning about memory leak in tests [21177] (backport #141) #160

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jul 11, 2024

Description

Fixes next message:

swig/python detected a memory leak of type 'eprosima::fastrtps::ResourceLimitedVector< unsigned char >::pointer *', no destructor found.

@Mergifyio backport 1.4.x 1.2.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Changes are API compatible.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #141 done by [Mergify](https://mergify.com).

@mergify mergify bot added the conflicts label Jul 11, 2024
Copy link
Author

mergify bot commented Jul 11, 2024

Cherry-pick of 7cbeb21 has failed:

On branch mergify/bp/1.2.x/pr-141
Your branch is up to date with 'origin/1.2.x'.

You are currently cherry-picking commit 7cbeb21.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fastdds_python/test/api/test_qos.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fastdds_python/src/swig/fastdds/dds/core/policy/QosPolicies.i
	both modified:   fastdds_python/src/swig/fastrtps/utils/collections/ResourceLimitedVector.i
	both modified:   fastdds_python/test/api/test_domainparticipant.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@JesusPoderoso JesusPoderoso added this to the v1.2.4 milestone Jul 11, 2024
(cherry picked from commit 7cbeb21)

Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: eduponz <[email protected]>
Co-authored-by: Ricardo González <[email protected]>
@MiguelCompany MiguelCompany force-pushed the mergify/bp/1.2.x/pr-141 branch from e719fd1 to 8caf888 Compare July 19, 2024 09:54
@MiguelCompany MiguelCompany self-requested a review July 19, 2024 09:54
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 19, 2024
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany merged commit 3eba0b1 into 1.2.x Jul 23, 2024
8 checks passed
@MiguelCompany MiguelCompany deleted the mergify/bp/1.2.x/pr-141 branch July 23, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants