Skip to content

Commit

Permalink
Fix EDP reliability timings (#5540)
Browse files Browse the repository at this point in the history
* EDP default configuration should be in milliseconds, not microseconds.

Signed-off-by: Tomoya Fujita <[email protected]>

* add the timeout for writer->wait_discovery().

Signed-off-by: Tomoya Fujita <[email protected]>

* Refs #22537: test fix

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Tomoya Fujita <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Co-authored-by: Mario Dominguez <[email protected]>
(cherry picked from commit b53a389)

# Conflicts:
#	src/cpp/rtps/builtin/discovery/endpoint/EDPSimple.cpp
  • Loading branch information
fujitatomoya authored and mergify[bot] committed Jan 9, 2025
1 parent 345c2e4 commit 9a2c44b
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
7 changes: 7 additions & 0 deletions src/cpp/rtps/builtin/discovery/endpoint/EDPSimple.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,17 @@ namespace fastrtps {
namespace rtps {

// Default configuration values for EDP entities.
<<<<<<< HEAD
static const Duration_t edp_heartbeat_period{1, 0}; // 1 second
static const Duration_t edp_nack_response_delay{0, 100 * 1000 }; // 100 milliseconds
static const Duration_t edp_nack_supression_duration{0, 10 * 1000}; // 10 milliseconds
static const Duration_t edp_heartbeat_response_delay{0, 10 * 1000}; // 10 milliseconds
=======
static const dds::Duration_t edp_heartbeat_period{1, 0}; // 1 second
static const dds::Duration_t edp_nack_response_delay{0, 100 * 1000 * 1000 }; // 100 milliseconds
static const dds::Duration_t edp_nack_supression_duration{0, 10 * 1000 * 1000}; // 10 milliseconds
static const dds::Duration_t edp_heartbeat_response_delay{0, 10 * 1000 * 1000}; // 10 milliseconds
>>>>>>> b53a3899 (Fix EDP reliability timings (#5540))

static const int32_t edp_reader_initial_reserved_caches = 1;
static const int32_t edp_writer_initial_reserved_caches = 20;
Expand Down
2 changes: 1 addition & 1 deletion test/blackbox/common/DDSBlackboxTestsStatistics.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -765,7 +765,7 @@ TEST(DDSStatistics, correct_deletion_upon_delete_contained_entities)
writer->init();
ASSERT_TRUE(writer->isInitialized());
writer->wait_discovery();
writer->send(*data, 10);
writer->send(*data, 200);
writer->destroy();
}));

Expand Down

0 comments on commit 9a2c44b

Please sign in to comment.