-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[22024] Improve OpenSSL
lifecycle handling (backport #5384)
#5406
Merged
MiguelCompany
merged 2 commits into
2.10.x
from
mergify/bp/mergify/bp/2.10.x/pr-5386/pr-5384
Jan 17, 2025
Merged
[22024] Improve OpenSSL
lifecycle handling (backport #5384)
#5406
MiguelCompany
merged 2 commits into
2.10.x
from
mergify/bp/mergify/bp/2.10.x/pr-5386/pr-5384
Jan 17, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-pick of 44310c4 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
14 tasks
@Mergifyio rebase |
✅ Branch has been successfully rebased |
MiguelCompany
force-pushed
the
mergify/bp/mergify/bp/2.10.x/pr-5386/pr-5384
branch
from
December 4, 2024 13:21
846ad54
to
cf0ad9e
Compare
* Refs #22024: Add BB test Signed-off-by: Mario Dominguez <[email protected]> * Refs #22024: Make OpenSSLInit Mayers singleton Signed-off-by: Mario Dominguez <[email protected]> * Refs #22024: Fix: Do not register atexit in OPenSSL. Instead, Comply with OpenSSL initialization and destruction. Signed-off-by: Mario Dominguez <[email protected]> * Refs #22024: Do not reference OpenSSLInit if security features are no present Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]> (cherry picked from commit 44310c4) # Conflicts: # src/cpp/rtps/RTPSDomainImpl.hpp
Signed-off-by: Mario Dominguez <[email protected]>
MiguelCompany
force-pushed
the
mergify/bp/mergify/bp/2.10.x/pr-5386/pr-5384
branch
from
December 4, 2024 13:28
cf0ad9e
to
e32322d
Compare
MiguelCompany
approved these changes
Jan 17, 2025
MiguelCompany
deleted the
mergify/bp/mergify/bp/2.10.x/pr-5386/pr-5384
branch
January 17, 2025 12:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a crash in
OpenSSL
provoked when theatexit
callback fromopenssl
is triggered upon process destruction, making it to trigger aSIGSEV
on an already releasedOpenSSL
resource.In addition,
OpenSSL
is now a Meyers singleton attached toRTPSDomainImpl
.In accordance with the best practices using OpenSSL and its documentation:
OpenSSL_init_crypto
(available in all versions along with theOPENSSL_INIT_NO_ATEXIT
option) that makesatexit
not being registered.atexit
is not registered, user has to explicitly callOpenSSL_cleanup()
(also, supported across versions).@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A New feature has been added to the
versions.md
file (if applicable).N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #5384 done by [Mergify](https://mergify.com).