Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22321] Benchmark example updated (backport #5460) #5500

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 17, 2024

Description

I remake the benchmark example to new example style maintaining the original functionality.

@Mergifyio backport 3.1.x 3.0.x

Fixes #5398

Contributor Checklist

  • Commit messages follow the project guidelines.

  • The code follows the style guidelines of this project.

  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A Any new/modified methods have been properly documented using Doxygen.

  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • Changes are API compatible.

  • New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #5460 done by [Mergify](https://mergify.com).

* Refs #22321: Benchmark example updated

Signed-off-by: Javier Gil Aviles <[email protected]>

* Refs #22321: Test CI for benchmark example and issue fixing

Signed-off-by: Javier Gil Aviles <[email protected]>

* Refs #22321: Fix type variable error

Signed-off-by: Javier Gil Aviles <[email protected]>

* Refs #22321: Corrections after review

Signed-off-by: Javier Gil Aviles <[email protected]>

* Refs #22321: Uncrustify fix

Signed-off-by: Javier Gil Aviles <[email protected]>

* Refs #22321: Uncrustified 2

Signed-off-by: Javier Gil Aviles <[email protected]>

* Refs #22321: Delate unused variable <sent> from PublisherApp.hpp

Signed-off-by: Javier Gil Aviles <[email protected]>

* Refs #22321: Extra corrections and fixes

Signed-off-by: Javier Gil Aviles <[email protected]>

* Refs #22321: Compose simplify for test

Signed-off-by: Javier Gil Aviles <[email protected]>

---------

Signed-off-by: Javier Gil Aviles <[email protected]>
(cherry picked from commit e99d6f3)

# Conflicts:
#	versions.md
@mergify mergify bot added the conflicts Backport PR wich git cherry pick failed label Dec 17, 2024
Copy link
Contributor Author

mergify bot commented Dec 17, 2024

Cherry-pick of e99d6f3 has failed:

On branch mergify/bp/3.1.x/pr-5460
Your branch is up to date with 'origin/3.1.x'.

You are currently cherry-picking commit e99d6f3f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   examples/CMakeLists.txt
	new file:   examples/cpp/benchmark/Application.cpp
	new file:   examples/cpp/benchmark/Application.hpp
	new file:   examples/cpp/benchmark/CLIParser.hpp
	new file:   examples/cpp/benchmark/CMakeLists.txt
	new file:   examples/cpp/benchmark/PublisherApp.cpp
	new file:   examples/cpp/benchmark/PublisherApp.hpp
	new file:   examples/cpp/benchmark/README.md
	new file:   examples/cpp/benchmark/SubscriberApp.cpp
	new file:   examples/cpp/benchmark/SubscriberApp.hpp
	new file:   examples/cpp/benchmark/benchmark_profile.xml
	new file:   examples/cpp/benchmark/main.cpp
	new file:   examples/cpp/benchmark/types/Benchmark.hpp
	new file:   examples/cpp/benchmark/types/Benchmark.idl
	new file:   examples/cpp/benchmark/types/BenchmarkCdrAux.hpp
	new file:   examples/cpp/benchmark/types/BenchmarkCdrAux.ipp
	new file:   examples/cpp/benchmark/types/BenchmarkPubSubTypes.cxx
	new file:   examples/cpp/benchmark/types/BenchmarkPubSubTypes.hpp
	new file:   examples/cpp/benchmark/types/BenchmarkTypeObjectSupport.cxx
	new file:   examples/cpp/benchmark/types/BenchmarkTypeObjectSupport.hpp
	new file:   examples/cpp/benchmark/types/Benchmark_big.hpp
	new file:   examples/cpp/benchmark/types/Benchmark_big.idl
	new file:   examples/cpp/benchmark/types/Benchmark_bigCdrAux.hpp
	new file:   examples/cpp/benchmark/types/Benchmark_bigCdrAux.ipp
	new file:   examples/cpp/benchmark/types/Benchmark_bigPubSubTypes.cxx
	new file:   examples/cpp/benchmark/types/Benchmark_bigPubSubTypes.hpp
	new file:   examples/cpp/benchmark/types/Benchmark_bigTypeObjectSupport.cxx
	new file:   examples/cpp/benchmark/types/Benchmark_bigTypeObjectSupport.hpp
	new file:   examples/cpp/benchmark/types/Benchmark_medium.hpp
	new file:   examples/cpp/benchmark/types/Benchmark_medium.idl
	new file:   examples/cpp/benchmark/types/Benchmark_mediumCdrAux.hpp
	new file:   examples/cpp/benchmark/types/Benchmark_mediumCdrAux.ipp
	new file:   examples/cpp/benchmark/types/Benchmark_mediumPubSubTypes.cxx
	new file:   examples/cpp/benchmark/types/Benchmark_mediumPubSubTypes.hpp
	new file:   examples/cpp/benchmark/types/Benchmark_mediumTypeObjectSupport.cxx
	new file:   examples/cpp/benchmark/types/Benchmark_mediumTypeObjectSupport.hpp
	new file:   examples/cpp/benchmark/types/Benchmark_small.hpp
	new file:   examples/cpp/benchmark/types/Benchmark_small.idl
	new file:   examples/cpp/benchmark/types/Benchmark_smallCdrAux.hpp
	new file:   examples/cpp/benchmark/types/Benchmark_smallCdrAux.ipp
	new file:   examples/cpp/benchmark/types/Benchmark_smallPubSubTypes.cxx
	new file:   examples/cpp/benchmark/types/Benchmark_smallPubSubTypes.hpp
	new file:   examples/cpp/benchmark/types/Benchmark_smallTypeObjectSupport.cxx
	new file:   examples/cpp/benchmark/types/Benchmark_smallTypeObjectSupport.hpp
	new file:   test/examples/benchmark.compose.yml
	new file:   test/examples/test_benchmark.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   versions.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Dec 17, 2024
13 tasks
@Mario-DL Mario-DL added this to the v3.1.2 milestone Dec 17, 2024
Signed-off-by: Javier Gil Aviles <[email protected]>
@Javgilavi Javgilavi removed the conflicts Backport PR wich git cherry pick failed label Dec 17, 2024
@Javgilavi Javgilavi requested review from richiprosima and removed request for richiprosima December 17, 2024 10:51
@github-actions github-actions bot added the ci-pending PR which CI is running label Dec 17, 2024
@Javgilavi Javgilavi removed the ci-pending PR which CI is running label Dec 18, 2024
@MiguelCompany MiguelCompany merged commit 678fd19 into 3.1.x Jan 10, 2025
21 checks passed
@MiguelCompany MiguelCompany deleted the mergify/bp/3.1.x/pr-5460 branch January 10, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants