-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[22427] Fast DDS EASY_MODE - Feature - XMLRPC Server #5551
Merged
Mario-DL
merged 23 commits into
feature/auto_ds_daemonized
from
feature/fastdds-impl/auto_ds_daemonized
Jan 22, 2025
Merged
[22427] Fast DDS EASY_MODE - Feature - XMLRPC Server #5551
Mario-DL
merged 23 commits into
feature/auto_ds_daemonized
from
feature/fastdds-impl/auto_ds_daemonized
Jan 22, 2025
+774
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cferreiragonz
force-pushed
the
feature/fastdds-impl/auto_ds_daemonized
branch
from
January 8, 2025 13:58
4df67d4
to
1d15ef7
Compare
cferreiragonz
requested review from
richiprosima
and removed request for
richiprosima
January 8, 2025 13:58
cferreiragonz
changed the base branch from
master
to
feature/auto_ds_daemonized
January 8, 2025 14:02
cferreiragonz
added
doc-pending
Issue or PR which is pending to be documented
versions-pending
needs-review
PR that is ready to be reviewed
labels
Jan 8, 2025
cferreiragonz
commented
Jan 8, 2025
cferreiragonz
force-pushed
the
feature/auto_ds_daemonized
branch
3 times, most recently
from
January 10, 2025 09:38
e7c0a85
to
6465cd4
Compare
13 tasks
Mario-DL
force-pushed
the
feature/fastdds-impl/auto_ds_daemonized
branch
from
January 10, 2025 10:28
5fdf099
to
96ef6db
Compare
cferreiragonz
force-pushed
the
feature/fastdds-impl/auto_ds_daemonized
branch
from
January 13, 2025 15:37
5a156eb
to
89506ac
Compare
cferreiragonz
requested review from
richiprosima
and removed request for
richiprosima
January 14, 2025 07:24
cferreiragonz
force-pushed
the
feature/auto_ds_daemonized
branch
from
January 15, 2025 13:50
55a05c7
to
308bc53
Compare
cferreiragonz
force-pushed
the
feature/fastdds-impl/auto_ds_daemonized
branch
from
January 15, 2025 13:58
353bcec
to
5917ac4
Compare
cferreiragonz
force-pushed
the
feature/auto_ds_daemonized
branch
from
January 15, 2025 14:18
308bc53
to
b03c362
Compare
cferreiragonz
force-pushed
the
feature/fastdds-impl/auto_ds_daemonized
branch
3 times, most recently
from
January 15, 2025 16:09
6f8ddb5
to
351c441
Compare
cferreiragonz
requested review from
richiprosima
and removed request for
richiprosima
January 15, 2025 16:10
cferreiragonz
force-pushed
the
feature/auto_ds_daemonized
branch
from
January 16, 2025 10:16
b03c362
to
e89400a
Compare
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
… BB tests Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
… a previous one Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Mario-DL
force-pushed
the
feature/fastdds-impl/auto_ds_daemonized
branch
from
January 21, 2025 15:45
36b4d48
to
71ac0df
Compare
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: Mario Domínguez López <[email protected]>
cferreiragonz
force-pushed
the
feature/fastdds-impl/auto_ds_daemonized
branch
from
January 21, 2025 21:13
71ac0df
to
092b595
Compare
cferreiragonz
requested review from
richiprosima
and removed request for
richiprosima
January 21, 2025 21:14
Mario-DL
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work @cferreiragonz 🥇
cferreiragonz
removed
needs-review
PR that is ready to be reviewed
ci-pending
PR which CI is running
labels
Jan 22, 2025
cferreiragonz
added a commit
that referenced
this pull request
Jan 22, 2025
* Refs #22352: Add preferred_domain_id to PubSubAPI Signed-off-by: Mario Dominguez <[email protected]> * Refs #22352: Refactor set_on_discovery_function in PubSubAPI Signed-off-by: Mario Dominguez <[email protected]> * Refs #22352: Add get_participants_matched() in PubSubAPI Signed-off-by: Mario Dominguez <[email protected]> * Refs #22352: Update BB tests with new APIs Signed-off-by: Mario Dominguez <[email protected]> * Refs #22352: Add Auto Discovery Mode BB tests Signed-off-by: Mario Dominguez <[email protected]> * Refs #22427: New DS_AUTO BuiltinTransport option Signed-off-by: Mario Dominguez <[email protected]> * Refs #22427: SystemCommandBuilder class Signed-off-by: Mario Dominguez <[email protected]> * Refs #22427: Feature Impl Signed-off-by: Mario Dominguez <[email protected]> * Refs #22427: Fix tests compilation in all platforms Signed-off-by: Mario Dominguez <[email protected]> * Refs #22427: Apply Carlo's review Signed-off-by: Mario Dominguez <[email protected]> * Refs #22427: stop background servers with stop instead of shutdown in BB tests Signed-off-by: Mario Dominguez <[email protected]> * Refs #22427: Update banner Signed-off-by: cferreiragonz <[email protected]> * Refs #22627: Rename DS_AUTO transport to P2P Signed-off-by: Mario Dominguez <[email protected]> * Refs #22627: Refactor BB tests with EASY_MODE Signed-off-by: Mario Dominguez <[email protected]> * Refs #22627: Refactor feature impl with EASY_MODE Signed-off-by: Mario Dominguez <[email protected]> * Refs #22627: Distinguish Log error if the EASY_MODE IP conflicts with a previous one Signed-off-by: Mario Dominguez <[email protected]> * Refs #22627: Review NIT Signed-off-by: Mario Dominguez <[email protected]> * Refs #22627: Feature use UDP for metatraffic Signed-off-by: Mario Dominguez <[email protected]> * Refs #22627: UDP metatraffic Cli Signed-off-by: Mario Dominguez <[email protected]> * Refs #22627: Feature with UDP BB tests Signed-off-by: Mario Dominguez <[email protected]> * Refs #22627: Remove unsued line Signed-off-by: Mario Dominguez <[email protected]> * Refs #22627: Feature with UDP CLI tests Signed-off-by: cferreiragonz <[email protected]> * Refs #22627: Avoid macro collision in MacOS Signed-off-by: Mario Domínguez López <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]> Signed-off-by: cferreiragonz <[email protected]> Signed-off-by: Mario Domínguez López <[email protected]> Co-authored-by: Mario Dominguez <[email protected]>
Mario-DL
added a commit
that referenced
this pull request
Jan 23, 2025
* Refs #22013: Add new port offset Signed-off-by: cferreiragonz <[email protected]> * Refs #22013: Add CLI keywords architecture Signed-off-by: cferreiragonz <[email protected]> * Refs #22106: Python -h/-e args Signed-off-by: cferreiragonz <[email protected]> * Refs #22106: 'getDiscoveryServerPort' Signed-off-by: cferreiragonz <[email protected]> * Refs #22106: Parse options in main Signed-off-by: cferreiragonz <[email protected]> * Refs #22106: Domain (-d) arg Signed-off-by: cferreiragonz <[email protected]> * Refs #22106: Justify Help message Signed-off-by: cferreiragonz <[email protected]> * Refs #22106: Create CliDiscoveryManager & remove server.cpp Signed-off-by: cferreiragonz <[email protected]> * Refs #22106: LIST keyword Signed-off-by: cferreiragonz <[email protected]> * Refs #22106: AUTO keyword Signed-off-by: cferreiragonz <[email protected]> * Refs #22106: STOP keyword Signed-off-by: cferreiragonz <[email protected]> * Refs #22106: Update server tests Signed-off-by: cferreiragonz <[email protected]> * Refs #22106: Refactor SERVER behavior Signed-off-by: cferreiragonz <[email protected]> * Refs #22106: ADD keyword Signed-off-by: cferreiragonz <[email protected]> * Refs #22106: Parse ROS_STATIC_PEERS Signed-off-by: cferreiragonz <[email protected]> * Refs #22106: SET keyword & minor fixes Signed-off-by: cferreiragonz <[email protected]> * Refs #22106: Uncrustify Signed-off-by: cferreiragonz <[email protected]> * Refs #22106: Remove debug log Signed-off-by: cferreiragonz <[email protected]> * Refs #22106: START keyword & doxygen Signed-off-by: cferreiragonz <[email protected]> * Refs #22106: print Domain ID Signed-off-by: cferreiragonz <[email protected]> * Refs #22106: Unittests Signed-off-by: cferreiragonz <[email protected]> * Refs #22106: Add SHM transport Signed-off-by: cferreiragonz <[email protected]> * Refs #22106: Make arguments const Signed-off-by: cferreiragonz <[email protected]> * Refs #22106: Use data_sharing directory Signed-off-by: cferreiragonz <[email protected]> * Refs #22106: Use Logs in CLI Signed-off-by: cferreiragonz <[email protected]> * Refs #22106: Support Windows & Mac commands Signed-off-by: cferreiragonz <[email protected]> * Refs #22106: Uncrustify Signed-off-by: cferreiragonz <[email protected]> * Refs #22106: Protect std::stoi & Add server name Signed-off-by: cferreiragonz <[email protected]> * Refs #22106: Fix MacOS build Signed-off-by: Mario Dominguez <[email protected]> * Refs #22106: Fix Windows build Signed-off-by: cferreiragonz <[email protected]> * Refs #22106: Add help/examples tests Signed-off-by: cferreiragonz <[email protected]> * Refs #22106: Rearrange methods to simplify windows def Signed-off-by: cferreiragonz <[email protected]> * Refs #22106: Workaround to solve Mac Tests Signed-off-by: cferreiragonz <[email protected]> * Refs #22106: Minor fixes Signed-off-by: cferreiragonz <[email protected]> * Refs #22518: Add Fast DDS XML-RPC Daemon Signed-off-by: cferreiragonz <[email protected]> * Refs #22518: Test enum Signed-off-by: cferreiragonz <[email protected]> * Refs #22518: Cancel fork in cpp tool Signed-off-by: cferreiragonz <[email protected]> * Refs #22518: Add parser tests Signed-off-by: cferreiragonz <[email protected]> * Refs #22518: Apply Revision Signed-off-by: cferreiragonz <[email protected]> * Refs #22518: Review - Use stop to shutdown server Signed-off-by: cferreiragonz <[email protected]> * Refs #22518: Apply Revision 2 Signed-off-by: cferreiragonz <[email protected]> * Refs #22623: Allow TCP reconnections Signed-off-by: cferreiragonz <[email protected]> * Refs #22518: Fix build in Ubuntu24 Signed-off-by: cferreiragonz <[email protected]> * Refs #22627: Add EASY_MODE to parser Signed-off-by: cferreiragonz <[email protected]> * Refs #22518: Improve unittest robustness Signed-off-by: cferreiragonz <[email protected]> * Fast DDS EASY_MODE - Feature - XMLRPC Server (#5551) * Refs #22352: Add preferred_domain_id to PubSubAPI Signed-off-by: Mario Dominguez <[email protected]> * Refs #22352: Refactor set_on_discovery_function in PubSubAPI Signed-off-by: Mario Dominguez <[email protected]> * Refs #22352: Add get_participants_matched() in PubSubAPI Signed-off-by: Mario Dominguez <[email protected]> * Refs #22352: Update BB tests with new APIs Signed-off-by: Mario Dominguez <[email protected]> * Refs #22352: Add Auto Discovery Mode BB tests Signed-off-by: Mario Dominguez <[email protected]> * Refs #22427: New DS_AUTO BuiltinTransport option Signed-off-by: Mario Dominguez <[email protected]> * Refs #22427: SystemCommandBuilder class Signed-off-by: Mario Dominguez <[email protected]> * Refs #22427: Feature Impl Signed-off-by: Mario Dominguez <[email protected]> * Refs #22427: Fix tests compilation in all platforms Signed-off-by: Mario Dominguez <[email protected]> * Refs #22427: Apply Carlo's review Signed-off-by: Mario Dominguez <[email protected]> * Refs #22427: stop background servers with stop instead of shutdown in BB tests Signed-off-by: Mario Dominguez <[email protected]> * Refs #22427: Update banner Signed-off-by: cferreiragonz <[email protected]> * Refs #22627: Rename DS_AUTO transport to P2P Signed-off-by: Mario Dominguez <[email protected]> * Refs #22627: Refactor BB tests with EASY_MODE Signed-off-by: Mario Dominguez <[email protected]> * Refs #22627: Refactor feature impl with EASY_MODE Signed-off-by: Mario Dominguez <[email protected]> * Refs #22627: Distinguish Log error if the EASY_MODE IP conflicts with a previous one Signed-off-by: Mario Dominguez <[email protected]> * Refs #22627: Review NIT Signed-off-by: Mario Dominguez <[email protected]> * Refs #22627: Feature use UDP for metatraffic Signed-off-by: Mario Dominguez <[email protected]> * Refs #22627: UDP metatraffic Cli Signed-off-by: Mario Dominguez <[email protected]> * Refs #22627: Feature with UDP BB tests Signed-off-by: Mario Dominguez <[email protected]> * Refs #22627: Remove unsued line Signed-off-by: Mario Dominguez <[email protected]> * Refs #22627: Feature with UDP CLI tests Signed-off-by: cferreiragonz <[email protected]> * Refs #22627: Avoid macro collision in MacOS Signed-off-by: Mario Domínguez López <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]> Signed-off-by: cferreiragonz <[email protected]> Signed-off-by: Mario Domínguez López <[email protected]> Co-authored-by: Mario Dominguez <[email protected]> * Refs #22627: logs, comments, versions, displays Signed-off-by: cferreiragonz <[email protected]> * Refs #22627: Review - Logs Signed-off-by: cferreiragonz <[email protected]> * Refs #22627: ROS2_EASY_MODE Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> Signed-off-by: Mario Dominguez <[email protected]> Signed-off-by: Mario Domínguez López <[email protected]> Co-authored-by: Mario Dominguez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the
Fast DDS Auto Discovery Server Mode
feature in Fast DDS.RTPSDomain
to parse the new environment variableEASY_MODE
and properly configure the RTPSParticipant to point to a local UDP Discovery Server.P2P
, targeting the new mode. It instantiates TCP and SHM transport for user data and UDP for metatrafficUnicast, relying on a Discovery Server for discovery purposes.SystemCommandBuilder
to build and make system calls within Fast DDS.Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist