[22317] Service feature implementation on CPP #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Javgilavi
force-pushed
the
feature/service_dev
branch
from
61eac3f to
e4d1e33
Compare
Mario-DL
requested changes
Jan 22, 2025
Javgilavi
force-pushed
the
feature/service_dev
branch
from
e4d1e33 to
233010d
Compare
Javgilavi
force-pushed
the
feature/service_dev
branch
from
233010d to
eea063a
Compare
Mario-DL
requested changes
Jan 23, 2025
| @@ -0,0 +1,164 @@ | |||
| // Copyright 2023 Proyectos y Sistemas de Mantenimiento SL (eProsima). | |||
There was a problem hiding this comment.
Suggested change
| // Copyright 2023 Proyectos y Sistemas de Mantenimiento SL (eProsima). | |
| // Copyright 2025 Proyectos y Sistemas de Mantenimiento SL (eProsima). |
Comment on lines
146
to
147
| matched_ = status.current_count; | ||
| std::cout << "Subscriber matched." << std::endl; |
There was a problem hiding this comment.
Spacing, and pls remove the std::cout
Applies elsewhere
| // Non-valid option | ||
| else | ||
| { | ||
| std::cout << status.current_count_change |
There was a problem hiding this comment.
This should be a EPROSIMA_LOG_ERROR if so
Comment on lines
121
to
122
| types::ResponseType res; | ||
| res = in; |
There was a problem hiding this comment.
I think these lines are not needed. Would apply in the OrchestratorNode too
|
|
||
| { | ||
| std::lock_guard<std::mutex> lock(this->mtx_); | ||
| this->res_ = res; |
There was a problem hiding this comment.
It is not so intutitive that the new operator = in RequestType and ResponseType takes a RequestTypeImpl* or ResponseTypeImpl*. It should take a RequestTypeImpl (not a pointer) . Please, change that and this line should be
this->res_ = *sample_in
Same suggestion applies for the OrchestratorNode
Signed-off-by: Javier Gil Aviles <[email protected]>
Signed-off-by: Javier Gil Aviles <[email protected]>
Javgilavi
force-pushed
the
feature/service_dev
branch
from
eea063a to
fe4b668
Compare
Signed-off-by: Javier Gil Aviles <[email protected]>
Javgilavi
force-pushed
the
feature/service_dev
branch
from
27d80e6 to
0cd2a24
Compare
Javgilavi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements all filea needed for the feature service on sustainml_cpp.
Depend on the PR #62