Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repository for Fast DDS 3.0.0 compatibility #101

Merged
merged 7 commits into from
May 16, 2024

Conversation

LuciaEchevarria99
Copy link
Contributor

No description provided.

@rsanchez15 rsanchez15 changed the title Update repository for FastDDS 3.0.0 compatibility Update repository for Fast DDS 3.0.0 compatibility Apr 30, 2024
Copy link
Collaborator

@rsanchez15 rsanchez15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch does not compile against Fast DDS 3.0.x-devel as DBQueue is missing now. We have to reimplement it internally (copy fastdds code to dev-utils)

cpp_utils/include/cpp_utils/ReturnCode.hpp Show resolved Hide resolved
cpp_utils/include/cpp_utils/wait/DBQueue.hpp Outdated Show resolved Hide resolved
cpp_utils/include/cpp_utils/wait/DBQueueWaitHandler.hpp Outdated Show resolved Hide resolved
cpp_utils/src/cpp/ReturnCode.cpp Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

Attention: Patch coverage is 49.27536% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 66.20%. Comparing base (35020ee) to head (3103ffd).
Report is 1 commits behind head on main.

Files Patch % Lines
cpp_utils/src/cpp/ReturnCode.cpp 36.66% 18 Missing and 1 partial ⚠️
cpp_utils/include/cpp_utils/queue/DBQueue.hpp 65.62% 0 Missing and 11 partials ⚠️
...include/cpp_utils/wait/impl/DBQueueWaitHandler.ipp 28.57% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   66.70%   66.20%   -0.51%     
==========================================
  Files          62       63       +1     
  Lines        1547     1604      +57     
  Branches      424      436      +12     
==========================================
+ Hits         1032     1062      +30     
- Misses        268      283      +15     
- Partials      247      259      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rsanchez15
rsanchez15 previously approved these changes May 16, 2024
Base automatically changed from ci/bump-1.x to main May 16, 2024 15:51
@rsanchez15 rsanchez15 dismissed their stale review May 16, 2024 15:51

The base branch was changed.

Signed-off-by: Lucia Echevarria <[email protected]>
Signed-off-by: Lucia Echevarria <[email protected]>
Signed-off-by: Lucia Echevarria <[email protected]>
…tor DBQueue code style to snake case

Signed-off-by: Lucia Echevarria <[email protected]>
Signed-off-by: Lucia Echevarria <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants