-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add files_to_ignore to ensure that only files that we want to copy over are actually moved #289
Conversation
This all seems to be working now. i now need to ensure that abc-feedback uses the same approach! addressing #278 |
Codecov Report
@@ Coverage Diff @@
## master #289 +/- ##
==========================================
+ Coverage 61.04% 62.27% +1.22%
==========================================
Files 13 13
Lines 706 729 +23
==========================================
+ Hits 431 454 +23
Misses 275 275
Continue to review full report at Codecov.
|
ok in this issue #292 i've added the create helper function task. i don't think that it will be hard to implement and it will be much easier to test. i am not going to implement this here nor will i implement tests for the feedback module. #293 this simply fixes the issue of moving files that we wish to ignore to assignment directories |
this will address #172 #278
Currently i keep running into an issue where files that i don't want to get moved around are being moved around. it's breaking the code in some cases. i think it's preferable to implement something that is config based to ensure these files are not being moved around by default. This will allow users working in different tools and such to specify "gitignore" files in the config file. And we could use it to create a .gitignore too in the future if that was of interest.
i believe this is an issue in create template as well so it might work better to make a little "get ignored files / directories" helper function ... but this fixes the most recent issue of it trying to copy over the .ipynb checkpoints directory.
TODO's here
which will allow the user to essentially specify which files to skip. i think we could
prepopulate this in the config file and then use it when the template is created AND
here when it's updated. I'm going to look at whether the copy files step is used multiple times. if so, i think a small copy files helper that grabs the config option and returns a list of things to copy could be useful...
question - could there be a scenario where someone may want to add an entire subdirectory to a template repo? Right now this will fail if they try that so i think we should atleast let it fail gracefully for the time being.