Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto update dist for renovate #67

Merged
merged 9 commits into from
Mar 26, 2024
Merged

Conversation

idodod
Copy link
Contributor

@idodod idodod commented Mar 26, 2024

Once Renovate updates a dependency we need to get the dist directory updated and checked in to the branch.
This PR defines a new target and gh workflow that will update dist and push it to the renovate branch

@idodod idodod marked this pull request as ready for review March 26, 2024 14:47
@idodod idodod requested a review from a team as a code owner March 26, 2024 14:47
update-dist-for-renovate:
FROM alpine/git
RUN git config --global user.name "renovate[bot]" && \
git config --global user.email "renovate[bot]@users.noreply.github.com" && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol..... I guess this is the reason PGP commit signing exists :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context - the only reason to do this is because by default when pushing changes to a Renovate branch, it decides to abandon the branch so it doesn't get updated.
For example, by default, if a PR is opened in order to update some dependency from v1.0.0 to v1.0.1 and while the PR stays open, v1.0.2 becomes available, Renovate will update the PR to try to update to the latest available version. So using the user name and email lets Renovate continue managing it.

@idodod idodod merged commit fcc9066 into main Mar 26, 2024
14 checks passed
@idodod idodod deleted the ido-auto-update-dist-for-renovate branch March 26, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants