Test cleanup part 2

[etiennebacher]

• Create new skip_*() helpers for tests instead of using .runThisTest easystats#294 (not sure if .runThisTest should be replaced by skip_on_cran() (what I did so far)
• About loading packages in tests easystats#363
• Run all tests on CI/CD for both release and development versions easystats#359

[vincentarelbundock]

Just here to say that I like this a lot.

[IndrajeetPatil]

(not sure if .runThisTest should be replaced by skip_on_cran() (what I did so far)

Yes! I think the intent was to skip the tests on CRAN and run only on devel versions of GitHub.

[etiennebacher]

I really have no clue anymore why R CMD check fails, it's all green for me.

Also, the dataset dat.bcg in metafor moved to metadat but it requires R >= 4.0.0 so it fails on older checks, @IndrajeetPatil where do I need to add this exception?

[IndrajeetPatil]

Fixed in easystats/workflows@7cf7cbb.

Re-triggering to see if the fix works.

[etiennebacher]

I really have no clue anymore why R CMD check fails, it's all green for me.

Actually devtools::test() passes but tests fail in devtools::check()

Fixed in easystats/workflows@7cf7cbb.

Thanks!

[etiennebacher]

Actually the problem is that check_outliers(mtcars, method = c("zscore", "iqr")) returns no outlier, so the test is wrong but which part? The expectation or the function? @rempsyc (test-check_outliers.R, test "multiple methods which")

[rempsyc]

That's my bad. I made a code change in #544. I'll fix it.

[codecov-commenter]

Codecov Report

Merging #567 (1b4dc82) into main (1ff1e20) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 1b4dc82 differs from pull request most recent head d870aec. Consider uploading reports for the commit d870aec to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #567   +/-   ##
=======================================
  Coverage   48.72%   48.72%           
=======================================
  Files          84       84           
  Lines        5642     5642           
=======================================
  Hits         2749     2749           
  Misses       2893     2893           

Impacted Files	Coverage Δ
R/check_outliers.R	82.43% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[IndrajeetPatil]

Thanks a ton, @etiennebacher! 💕

That was a lot of work and we really appreciate it.