Make this demo works again #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limhenry
commented
Jan 13, 2017
limhenry
commented
- Force reload to https since it's required by the camera API
- Update Google Font to https
- Fix image not showing after pressing the "Snapshot" button
1. Force reload to https since it's required by the camera API 2. Update Google Font to https 3. Fix image not showing after pressing the "Snapshot" button
ebidel
requested changes
Jan 15, 2017
| @@ -154,6 +154,12 @@ | |||
| </article> | |||
| <canvas id="photo" style="display:none"></canvas> | |||
| <script> | |||
|
|
|||
|
|
|||
| if (location.protocol != 'https:'){ | |||
There was a problem hiding this comment.
if (location.protocol !== 'https:') {
|
|
||
|
|
||
| if (location.protocol != 'https:'){ | ||
| location.href = 'https:' + window.location.href.substring(window.location.protocol.length); |
There was a problem hiding this comment.
I think this would work:
location.protocol = 'https:';
There was a problem hiding this comment.
yeah. this is actually better :)
| @@ -227,9 +233,12 @@ | |||
| intervalId = null; | |||
| return; | |||
| } | |||
|
|
|||
| document.getElementById("monitor").height = video.videoHeight; | |||
There was a problem hiding this comment.
cache and dry it up:
const monitor = document.getElementById('monitor');
monitor.height = video.videoHeight;
monitor.width = video.videoWidth;
limhenry
commented
Jan 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.