Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few minor fixes #173

Merged
merged 4 commits into from
Feb 5, 2025
Merged

A few minor fixes #173

merged 4 commits into from
Feb 5, 2025

Conversation

Rafnuss
Copy link
Contributor

@Rafnuss Rafnuss commented Jan 9, 2025

  1. ExportAs is running for a zenodo draft and returned an html page. Suggesting a fix for checking for is_draft()Note that it actually works on the browser with "? preview=1" but requires authentification.
  2. Seems like there was a typo with uppercase ZENODO vs zenodo.
  3. setSubjects is actually adding subjects rather than starting from an empty list. Suggesting a fix for this.

@Rafnuss Rafnuss changed the title Fix checking for draft A few minor fixes Jan 9, 2025
@eblondel eblondel merged commit 0f85c25 into eblondel:master Feb 5, 2025
1 check passed
@eblondel
Copy link
Owner

eblondel commented Feb 5, 2025

Thanks @Rafnuss apologies for the delay, i've completely forgot about your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants