-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make truncate a no-op when count=None
and when=None
#57
Labels
TODO
Added to roadmap
Comments
mjkanji
changed the title
Make truncate a no-op when count=None and when=None
Make truncate a no-op when Jan 21, 2025
count=None
and when=None
This was referenced Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It's a common pattern to have some limit that you set to a small int for testing and None for prod jobs. streamable currently raises an error when both
count
andwhen
equalNone
. Instead, it should be a no-op that simply returns the input stream/iterable without doing anything.This is especially useful when working with env vars (where if the value is not set, then
os.getenv
returns None).The text was updated successfully, but these errors were encountered: