Add parseTypeName method to CommandParser #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx990
suggested changes
Feb 20, 2025
src/stdfblib/ita/CommandParser.cpp
Outdated
| return -1; | ||
| } | ||
| std::string result = paTypeName.substr(0, endIndex); | ||
| if(!paIdentifier.pushBack(CStringDictionary::getInstance().insert(result.c_str()))){ |
There was a problem hiding this comment.
I would suggest using
4diac-forte/src/core/stringdict.h
Line 60 in d1afbde
There was a problem hiding this comment.
This is also useful with the string_views, to set the correct string length
src/stdfblib/ita/CommandParser.cpp
Outdated
| @@ -338,6 +338,18 @@ int CommandParser::parseIdentifier(char *paIdentifierStart, forte::core::TNameId | |||
| return -1; | |||
| } | |||
|
|
|||
| int CommandParser::parseTypeName(std::string paTypeName, forte::core::TNameIdentifier &paIdentifier){ | |||
There was a problem hiding this comment.
Please note that this will allocate and copy the entire buffer until the end each time this is called. Maybe you could use a std::string_view instead?
There was a problem hiding this comment.
Yeah, that makes sense. I replaced the strings with string_view objects. Thanks for pointing that out.
m-meingast
force-pushed
the
#2287-configuredStructs_parser
branch
from
745f3f6 to
bce68f3
Compare
mx990
approved these changes
Feb 20, 2025
azoitl
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use parseTypeName to parse the CreateFB request instead of parseIdentifier