Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ant task check dependencies #465

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

pazi146
Copy link

@pazi146 pazi146 commented Sep 10, 2024

  • checks for unused dependencies

Copy link

github-actions bot commented Sep 10, 2024

Test Results

   109 files  + 2     109 suites  +2   49s ⏱️ +2s
27 518 tests +33  27 518 ✅ +33  0 💤 ±0  0 ❌ ±0 
27 519 runs  +33  27 519 ✅ +33  0 💤 ±0  0 ❌ ±0 

Results for commit 5c246d9. ± Comparison against base commit 281a7dc.

This pull request removes 2 and adds 35 tests. Note that renamed tests count towards both.
org.eclipse.fordiac.ide.test.model.eval.fb.SimpleFBEvaluatorTest ‑ testDirectlyDerivedAttribute
org.eclipse.fordiac.ide.test.model.eval.fb.SimpleFBEvaluatorTest ‑ testStructAttribute
org.eclipse.fordiac.ide.test.model.eval.variable.VariableOperationTest ‑ testEvaluateResultType
org.eclipse.fordiac.ide.test.model.eval.variable.VariableOperationTest ‑ testEvaluateValueForDataType
org.eclipse.fordiac.ide.test.model.eval.variable.VariableOperationTest ‑ testGetAllDependencies
org.eclipse.fordiac.ide.test.model.eval.variable.VariableOperationTest ‑ testGetDeclaredInitialValue
org.eclipse.fordiac.ide.test.model.eval.variable.VariableOperationTest ‑ testGetDependenciesForAttribute
org.eclipse.fordiac.ide.test.model.eval.variable.VariableOperationTest ‑ testGetDependenciesForVarDeclaration
org.eclipse.fordiac.ide.test.model.eval.variable.VariableOperationTest ‑ testGetInheritedInitialValue
org.eclipse.fordiac.ide.test.model.eval.variable.VariableOperationTest ‑ testGetInitialValue
org.eclipse.fordiac.ide.test.model.eval.variable.VariableOperationTest ‑ testHasDeclaredInitialValue
org.eclipse.fordiac.ide.test.model.eval.variable.VariableOperationTest ‑ testHasInheritedInitialValue
…

♻️ This comment has been updated with latest results.

@@ -9,7 +9,6 @@ Bundle-ActivationPolicy: lazy
Require-Bundle: org.eclipse.fordiac.ide.globalconstantseditor.ui,
org.eclipse.xtext.testing,
org.eclipse.xtext.xbase.testing,
org.eclipse.xtext.xbase.junit,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be at least a seperate commit

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching that

@ernstblechaPT
Copy link

I have tested the ant-task with a new, empty project (no instances in appliction, no system configured):

Unused dependencies detected: convert, signalprocessing, net, utils, math, devices, segments, reconfiguration, resources

I don't see why the rest of the linked libraries are not listed as well?

- checks for unused dependencies
@oberlehner
Copy link
Contributor

iec61131-3 is also missing.

@pazi146
Copy link
Author

pazi146 commented Sep 23, 2024

Some standard libraries depend on others:

  • convert depends on core
  • events depends on iec61131-3
  • iec61131-3 depends on core
  • net depends on core
  • rtevents depends on core and events
  • utils depends on core

Result: core, events and iec61131-3 will not show as unused when including all standard libraries

@oberlehner oberlehner merged commit d2222c4 into eclipse-4diac:develop Sep 24, 2024
4 checks passed
@pazi146 pazi146 deleted the antCheckDependency branch September 24, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants