Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable seamless connections between graphical editors #530

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

mx990
Copy link
Member

@mx990 mx990 commented Sep 20, 2024

This is currently a rough proof of concept. It attempts to find the target in another editor based on the current mouse position and then feed that as a converted mouse event to the tool implementation. There are some missing checks and connection feedback does not work at the moment.

Copy link

github-actions bot commented Sep 20, 2024

Test Results

   111 files  +   68     111 suites  +68   49s ⏱️ +14s
29 174 tests +7 008  29 174 ✅ +7 008  0 💤 ±0  0 ❌ ±0 
29 175 runs  +7 008  29 175 ✅ +7 008  0 💤 ±0  0 ❌ ±0 

Results for commit 0eafdb9. ± Comparison against base commit 113a2f9.

♻️ This comment has been updated with latest results.

mx990 and others added 6 commits January 21, 2025 23:23
Add custom autoexpose helper for viewer drag autoscroll with larger
default threshold and acceleration depending on distance from the edges.
To make view searching more independent from the currently used tool it
is moved to an own FBNetworkEditDomain.
The marquee selection tried to remove the feedback figure from the wrong
viewer when moving on a split editor. The coordinates are still not
calculated correctly which leads to "jumps" in the selection when
crossing the editor border.
Override mouse hover to avoid accidentally nulling viewer references.
@azoitl azoitl force-pushed the editorSplitSeamlessConnections2 branch from e7b51b0 to 0eafdb9 Compare January 21, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants