Open Type Editor from Instance Viewer #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alliuqemal
commented
Jan 23, 2025
alliuqemal
commented
- added "Open Type in Editor" on popup menu of typed and untyped subapps
- updated OpenTypeHandler to support opening typed subapps
- open with breadcrumb when opening untyped subapp inside typed subapp
alliuqemal
force-pushed
the
feature/type-editor-menu
branch
from
78c9f2c to
050c8f6
Compare
oberlehner
reviewed
Jan 25, 2025
| if (obj instanceof final EditPart ep) { | ||
| obj = ep.getModel(); | ||
| } | ||
|
|
||
| final LibraryElement type = switch (obj) { | ||
| final EObject type = switch (obj) { |
There was a problem hiding this comment.
rename to eObject, its not always a type
oberlehner
reviewed
Jan 25, 2025
| return null; | ||
| } | ||
|
|
||
| } | ||
| private static EObject getTypeFromFbn(final FBNetwork fbn) { |
There was a problem hiding this comment.
rename to getEObjectForOpening
oberlehner
reviewed
Jan 25, 2025
| if (element.eContainer() instanceof final TypedSubApp tsa) { | ||
| subAppNames.add(tsa.getName()); | ||
|
|
||
| return getUntypedSubApp(subAppNames.reversed(), tsa.getType()); |
There was a problem hiding this comment.
rename to :
getMatchingSubappFromType
|
Please rename the marked elements to increase code readability. |
alliuqemal
force-pushed
the
feature/type-editor-menu
branch
from
050c8f6 to
fb13580
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.