Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

Rust client library and plugable databroker cli #675

Merged

Conversation

lukasmittag
Copy link
Contributor

@lukasmittag lukasmittag commented Sep 27, 2023

This PR addresses the need of a client library for rust for the new API (kuksa.val.v1) and makes the databroker-cli plugable.

To try this PR you need to know that per default it will be built with the old API client lib. If you want to use the new one use

cargo run --bin databroker-cli 

or

cargo run --bin databroker-cli --protocol kuksa-val-v1

@erikbosch
Copy link
Contributor

How does Rust compiler handle features? Does it ignore features not included (like old fashioned #ifdef) or does it anyway compile them even if it does not include them in result.

If it ignore it totally - would it then be an idea to extend our CI so that it also builds the "feature_kuksa" variant, to make sure that we do not introduce any regressions that can be detected at compile time, i.e. that all code is compiled by CI.

@lukasmittag
Copy link
Contributor Author

How does Rust compiler handle features? Does it ignore features not included (like old fashioned #ifdef) or does it anyway compile them even if it does not include them in result.

If it ignore it totally - would it then be an idea to extend our CI so that it also builds the "feature_kuksa" variant, to make sure that we do not introduce any regressions that can be detected at compile time, i.e. that all code is compiled by CI.

Yes that needs to be added. Good point!

@lukasmittag
Copy link
Contributor Author

lukasmittag commented Sep 29, 2023

cargo clippy --all-targets --no-default-features --features feature_kuksa -- -W warnings -D warnings

would this be enough or would you actually fully build it

@lukasmittag lukasmittag marked this pull request as ready for review October 4, 2023 11:09
@lukasmittag lukasmittag requested a review from argerus October 4, 2023 11:09
@lukasmittag lukasmittag marked this pull request as draft October 9, 2023 11:28
@lukasmittag lukasmittag marked this pull request as ready for review November 2, 2023 09:00
[package]
name = "common"
version = "0.1.0"
authors = ["Robert Bosch GmbH"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of the release I replaced most instances of this line with "Eclipse KUKSA Project" after a discussion with Sebastian. Could be good to do that also for the new files

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, can we change this @lukasmittag ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukasmittag lukasmittag force-pushed the feature/rust_client_lib branch from afe6308 to b23ce7a Compare December 5, 2023 19:12
@SebastianSchildt SebastianSchildt merged commit b896a39 into eclipse-archived:master Dec 7, 2023
11 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants