-
Notifications
You must be signed in to change notification settings - Fork 51
Rust client library and plugable databroker cli #675
Rust client library and plugable databroker cli #675
Conversation
How does Rust compiler handle features? Does it ignore features not included (like old fashioned If it ignore it totally - would it then be an idea to extend our CI so that it also builds the "feature_kuksa" variant, to make sure that we do not introduce any regressions that can be detected at compile time, i.e. that all code is compiled by CI. |
Yes that needs to be added. Good point! |
would this be enough or would you actually fully build it |
kuksa_databroker/lib/Cargo.toml
Outdated
[package] | ||
name = "common" | ||
version = "0.1.0" | ||
authors = ["Robert Bosch GmbH"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As part of the release I replaced most instances of this line with "Eclipse KUKSA Project" after a discussion with Sebastian. Could be good to do that also for the new files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, can we change this @lukasmittag ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done @SebastianSchildt
09d8359
to
28edd67
Compare
…rough protcol option
afe6308
to
b23ce7a
Compare
This PR addresses the need of a client library for rust for the new API (kuksa.val.v1) and makes the databroker-cli plugable.
To try this PR you need to know that per default it will be built with the old API client lib. If you want to use the new one use
or