Update the GitHub oauth configuration page (#2734)

* Update the GitHub oauth configuration page Signed-off-by: ivinokur <[email protected]> * Update modules/administration-guide/partials/proc_applying-the-github-oauth-app-secret.adoc Co-authored-by: Ilya Buziuk <[email protected]> --------- Signed-off-by: ivinokur <[email protected]> Co-authored-by: Ilya Buziuk <[email protected]>
eclipse-che · May 23, 2024 · ca4e408 · ca4e408
1 parent e333cc9
commit ca4e408
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/...es/administration-guide/partials/proc_applying-the-github-oauth-app-secret.adoc b/...es/administration-guide/partials/proc_applying-the-github-oauth-app-secret.adoc
@@ -36,15 +36,15 @@ metadata:
   annotations:
     che.eclipse.org/oauth-scm-server: github
     che.eclipse.org/scm-server-endpoint: __<github_server_url>__ <2>
-    che.eclipse.org/scm-github-disable-subdomain-isolation: true <3>
+    che.eclipse.org/scm-github-disable-subdomain-isolation: 'false' <3>
 type: Opaque
 stringData:
   id: __<GitHub_OAuth_Client_ID>__ <4>
   secret: __<GitHub_OAuth_Client_Secret>__ <5>
 ----
 <1> The {prod-short} namespace. The default is `{prod-namespace}`.
 <2> This depends on the GitHub product your organization is using: When hosting repositories on GitHub.com or GitHub Enterprise Cloud, omit this line or enter the default `https://github.com`. When hosting repositories on GitHub Enterprise Server, enter the GitHub Enterprise Server URL.
-<3> This line is only added for GitHub Enterprise Server with disabled link:https://docs.github.com/en/enterprise-server/admin/configuration/hardening-security-for-your-enterprise/enabling-subdomain-isolation#about-subdomain-isolation[subdomain isolation] option. If the subdomain isolation option is enabled on GitHub Enterprise Server, you must either omit this annotation or set it to `false`.
+<3> If you are using GitHub Enterprise Server with a disabled link:https://docs.github.com/en/enterprise-server/admin/configuration/hardening-security-for-your-enterprise/enabling-subdomain-isolation#about-subdomain-isolation[subdomain isolation] option, you must set the annotation to `true`, otherwise you can either omit the annotation or set it to `false`.
 <4> The *GitHub OAuth Client ID*.
 <5> The *GitHub OAuth Client Secret*.