Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed devfile registry #2787

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

deerskindoll
Copy link
Contributor

What does this pull request change?

removed mentions of devfile registry

What issues does this pull request fix or reference?

eclipse-che/che#23112

Specify the version of the product this pull request applies to

main, 7.90.x

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@deerskindoll deerskindoll requested a review from a team as a code owner September 2, 2024 22:33
@deerskindoll deerskindoll requested a review from svor September 2, 2024 22:33
Copy link

github-actions bot commented Sep 2, 2024

🎊 Navigate the preview: https://66dec07290eba40f70bc6767--eclipse-che-docs-pr.netlify.app 🎊

Copy link

github-actions bot commented Sep 2, 2024

Click here to review and test in web IDE: Contribute

@deerskindoll
Copy link
Contributor Author

UPSTREAM ONLY: need to mention that https://registry.devfile.io is a default registry right now

@deerskindoll deerskindoll changed the title [DRAFT] fix: removed devfile registry fix: removed devfile registry Sep 5, 2024
@deerskindoll
Copy link
Contributor Author

@tolusha please check if this works for you, I can add more info to the upstream devfile registry page

@tolusha
Copy link
Contributor

tolusha commented Sep 6, 2024

We have to remove the devfile registry from the image as well
https://66da3150f9a7e5a67bc2d5ac--eclipse-che-docs-pr.netlify.app/docs/next/administration-guide/server-components/

@svor
Copy link
Contributor

svor commented Sep 6, 2024

here is an extra character: {Devfile Registry in https://github.com/eclipse-che/che-docs/blob/main/modules/end-user-guide/pages/devfile-introduction.adoc?plain=1#L24

Copy link
Contributor

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svor svor self-requested a review September 9, 2024 08:03
@deerskindoll
Copy link
Contributor Author

@deerskindoll this image should be updated as well https://66db1417b00b1b9b92d31f2a--eclipse-che-docs-pr.netlify.app/docs/next/administration-guide/gateway/

please remove Devfile registry

I removed devfile registry from all diagrams

Copy link
Contributor

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@deerskindoll deerskindoll merged commit 186138a into eclipse-che:main Sep 9, 2024
6 checks passed
deerskindoll added a commit that referenced this pull request Sep 9, 2024
* removed devfile registry

* add devfile.io

* update

* remove devfile registry from diagrams
deerskindoll added a commit that referenced this pull request Sep 9, 2024
* removed devfile registry

* add devfile.io

* update

* remove devfile registry from diagrams
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants