feat: Don't reset the number of replicas on deployment update

[tolusha]

What does this PR do?

• Don't reset the number of replicas on deployment update

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#22067

How to test this PR?

on Minikube

./build/scripts/minikube-tests/test-operator-from-sources.sh

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• Development resource are up to date
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@tolusha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v14-che-behind-proxy	a97aa92	link	true	/test v14-che-behind-proxy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[devstudio-release]

Build 3.12 :: operator_3.x/345: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: sync-to-downstream_3.x/6094: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: get-sources-rhpkg-container-build_3.x/5980: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: push-latest-container-to-quay_3.x/4254: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: get-sources-rhpkg-container-build_3.x/5980:

devspaces-operator : 3.x :: Build 58468688 : quay.io/devspaces/devspaces-rhel8-operator:3.12-16
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/4254 triggered

[devstudio-release]

Build 3.12 :: update-digests_3.x/5698: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: operator_3.x/345:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/6094 triggered

[devstudio-release]

Build 3.12 :: operator-bundle_3.x/2583: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: sync-to-downstream_3.x/6095: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: get-sources-rhpkg-container-build_3.x/5981: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: push-latest-container-to-quay_3.x/4255: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: copyIIBsToQuay/2451: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: get-sources-rhpkg-container-build_3.x/5981:

devspaces-operator-bundle : 3.x :: Build 58469851 : quay.io/devspaces/devspaces-operator-bundle:3.12-140
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/4255 triggered;

Bundle CSV related images:
- quay.io/devspaces/code-rhel8:3.12-38
- quay.io/devspaces/configbump-rhel8:3.12-8
- quay.io/devspaces/dashboard-rhel8:3.12-28
- quay.io/devspaces/devfileregistry-rhel8:3.12-68
- quay.io/devspaces/devspaces-rhel8-operator:3.12-16
- quay.io/devspaces/idea-rhel8:3.12-8
- quay.io/devspaces/pluginregistry-rhel8:3.12-15
- quay.io/devspaces/server-rhel8:3.12-29
- quay.io/devspaces/traefik-rhel8:3.12-11
- quay.io/devspaces/udi-rhel8:3.12-11
= registry.redhat.io/openshift4/ose-kube-rbac-proxy:v4.12.0-202401101650.p0.gb17014f.assembly.stream
= registry.redhat.io/openshift4/ose-oauth-proxy:v4.12.0-202401101650.p0.g03e5b13.assembly.stream
= registry.redhat.io/rhscl/mongodb-36-rhel7:1-50
= registry.redhat.io/ubi8/ubi-minimal:8.8-1072.1697626218

[devstudio-release]

Build 3.12 :: sync-to-downstream_3.x/6095:

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5981 triggered; /job/DS_CI/job/dsc_3.x triggered;

[devstudio-release]

Build 3.12 :: operator-bundle_3.x/2583:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/6095 triggered

[devstudio-release]

Build 3.12 :: update-digests_3.x/5698:

Detected new images: rebuild operator-bundle
* devspaces-operator; /DS_CI/operator-bundle_3.x/2583 triggered

[devstudio-release]

Build 3.12 :: dsc_3.x/1780: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: dsc_3.x/1780:

3.12.0-CI

[devstudio-release]

Build 3.12 :: copyIIBsToQuay/2451:

3.12
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.12-140
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.21-7
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.12-v4.15-658768-s390x
  + quay.io/devspaces/iib:3.12-v4.15-s390x
  + quay.io/devspaces/iib:next-v4.15-s390x
  + quay.io/devspaces/iib:3.12-v4.14-658746-533291-s390x
  + quay.io/devspaces/iib:3.12-v4.14-s390x
  + quay.io/devspaces/iib:next-v4.14-s390x
  + quay.io/devspaces/iib:3.12-v4.13-658732-533286-s390x
  + quay.io/devspaces/iib:3.12-v4.13-s390x
  + quay.io/devspaces/iib:next-v4.13-s390x
  + quay.io/devspaces/iib:3.12-v4.12-658721-533281-s390x
  + quay.io/devspaces/iib:3.12-v4.12-s390x
  + quay.io/devspaces/iib:next-v4.12-s390x
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.12-v4.15-658768-x86_64
  + quay.io/devspaces/iib:3.12-v4.15-x86_64
  + quay.io/devspaces/iib:next-v4.15-x86_64
  + quay.io/devspaces/iib:3.12-v4.14-658746-533291-x86_64
  + quay.io/devspaces/iib:3.12-v4.14-x86_64
  + quay.io/devspaces/iib:next-v4.14-x86_64
  + quay.io/devspaces/iib:3.12-v4.13-658732-533286-x86_64
  + quay.io/devspaces/iib:3.12-v4.13-x86_64
  + quay.io/devspaces/iib:next-v4.13-x86_64
  + quay.io/devspaces/iib:3.12-v4.12-658721-533281-x86_64
  + quay.io/devspaces/iib:3.12-v4.12-x86_64
  + quay.io/devspaces/iib:next-v4.12-x86_64
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.12-v4.15-658768-ppc64le
  + quay.io/devspaces/iib:3.12-v4.15-ppc64le
  + quay.io/devspaces/iib:next-v4.15-ppc64le
  + quay.io/devspaces/iib:3.12-v4.14-658746-533291-ppc64le
  + quay.io/devspaces/iib:3.12-v4.14-ppc64le
  + quay.io/devspaces/iib:next-v4.14-ppc64le
  + quay.io/devspaces/iib:3.12-v4.13-658732-533286-ppc64le
  + quay.io/devspaces/iib:3.12-v4.13-ppc64le
  + quay.io/devspaces/iib:next-v4.13-ppc64le
  + quay.io/devspaces/iib:3.12-v4.12-658721-533281-ppc64le
  + quay.io/devspaces/iib:3.12-v4.12-ppc64le
  + quay.io/devspaces/iib:next-v4.12-ppc64le

[devstudio-release]

Build 3.12 :: operator-bundle_3.x/2584: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: sync-to-downstream_3.x/6098: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: operator-bundle_3.x/2593: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: sync-to-downstream_3.x/6120: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: get-sources-rhpkg-container-build_3.x/6021: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: push-latest-container-to-quay_3.x/4277: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: copyIIBsToQuay/2461: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: get-sources-rhpkg-container-build_3.x/6021:

devspaces-operator-bundle : 3.x :: Build 58567621 : quay.io/devspaces/devspaces-operator-bundle:3.12-150
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/4277 triggered;

Bundle CSV related images:
- quay.io/devspaces/code-rhel8:3.12-46
- quay.io/devspaces/configbump-rhel8:3.12-8
- quay.io/devspaces/dashboard-rhel8:3.12-28
- quay.io/devspaces/devfileregistry-rhel8:3.12-70
- quay.io/devspaces/devspaces-rhel8-operator:3.12-16
- quay.io/devspaces/idea-rhel8:3.12-8
- quay.io/devspaces/pluginregistry-rhel8:3.12-15
- quay.io/devspaces/server-rhel8:3.12-29
- quay.io/devspaces/traefik-rhel8:3.12-11
- quay.io/devspaces/udi-rhel8:3.12-11
= registry.redhat.io/openshift4/ose-kube-rbac-proxy:v4.12.0-202401190520.p0.gb17014f.assembly.stream
= registry.redhat.io/openshift4/ose-oauth-proxy:v4.12.0-202401190520.p0.g03e5b13.assembly.stream
= registry.redhat.io/rhscl/mongodb-36-rhel7:1-50
= registry.redhat.io/ubi8/ubi-minimal:8.8-1072.1697626218

[devstudio-release]

Build 3.12 :: sync-to-downstream_3.x/6120:

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/6021 triggered; /job/DS_CI/job/dsc_3.x triggered;

[devstudio-release]

Build 3.12 :: operator-bundle_3.x/2593:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/6120 triggered

[devstudio-release]

Build 3.12 :: dsc_3.x/1790: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: dsc_3.x/1790:

3.12.0-CI

[devstudio-release]

Build 3.12 :: operator-bundle_3.x/2594: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: sync-to-downstream_3.x/6124: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: get-sources-rhpkg-container-build_3.x/6023: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: get-sources-rhpkg-container-build_3.x/6023:

devspaces-operator-bundle : 3.x :: Failed in 58571147 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

[devstudio-release]

Build 3.12 :: operator-bundle_3.x/2595: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: sync-to-downstream_3.x/6127: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: get-sources-rhpkg-container-build_3.x/6024: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: get-sources-rhpkg-container-build_3.x/6024:

devspaces-operator-bundle : 3.x :: Failed in 58573670 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

[devstudio-release]

Build 3.12 :: operator-bundle_3.x/2596: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: sync-to-downstream_3.x/6129: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: get-sources-rhpkg-container-build_3.x/6026: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: get-sources-rhpkg-container-build_3.x/6026:

devspaces-operator-bundle : 3.x :: Failed in 58579346 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

[devstudio-release]

Build 3.12 :: operator-bundle_3.x/2597: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: sync-to-downstream_3.x/6130: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: get-sources-rhpkg-container-build_3.x/6027: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: get-sources-rhpkg-container-build_3.x/6027:

devspaces-operator-bundle : 3.x :: Failed in 58583020 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

[devstudio-release]

Build 3.12 :: operator-bundle_3.x/2598: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: sync-to-downstream_3.x/6131: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: get-sources-rhpkg-container-build_3.x/6028: Console, Changes, Git Data

[devstudio-release]

Build 3.12 :: get-sources-rhpkg-container-build_3.x/6028:

devspaces-operator-bundle : 3.x :: Failed in 58583666 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay