Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cookie_refresh for oauth2-proxy. #1810

Closed

Conversation

monaka
Copy link
Member

@monaka monaka commented Feb 18, 2024

This is a draft. I'll fill in the description later.

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#21376
eclipse-che/che#22130
eclipse-che/che#22765

How to test this PR?

  1. Prepare a patch file if needed:
cat > /tmp/cr-patch.yaml <<EOF
apiVersion: org.eclipse.che/v2
kind: CheCluster
spec: {}
EOF
  1. Deploy the operator:

OpenShift

./build/scripts/olm/test-catalog-from-sources.sh --cr-patch-yaml /tmp/cr-patch.yaml

on Minikube

./build/scripts/minikube-tests/test-operator-from-sources.sh --cr-patch-yaml /tmp/cr-patch.yaml

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Copy link

openshift-ci bot commented Feb 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Feb 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: monaka

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (1ae0142) 59.75% compared to head (627d71b) 59.73%.

Files Patch % Lines
api/v2/zz_generated.deepcopy.go 0.00% 5 Missing ⚠️
pkg/deploy/gateway/oauth_proxy.go 70.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1810      +/-   ##
==========================================
- Coverage   59.75%   59.73%   -0.03%     
==========================================
  Files          74       74              
  Lines        9107     9122      +15     
==========================================
+ Hits         5442     5449       +7     
- Misses       3290     3297       +7     
- Partials      375      376       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@monaka monaka force-pushed the pr-add-CookieRefreshSeconds branch 2 times, most recently from bf2682f to 8ea7e48 Compare February 18, 2024 06:23
@monaka monaka force-pushed the pr-add-CookieRefreshSeconds branch from 8ea7e48 to 627d71b Compare February 18, 2024 06:42
@monaka
Copy link
Member Author

monaka commented Feb 19, 2024

I believe this will work as expected.
But issues will be resolved by another way.
So I close this.

@monaka monaka closed this Feb 19, 2024
@monaka monaka deleted the pr-add-CookieRefreshSeconds branch February 19, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant