Add spec.devEnvironments.runtimeClassName field to CR

[dkwon17]

What does this PR do?

Fixes eclipse-che/che#23032

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

1. Deploy the operator:

OpenShift

./build/scripts/olm/test-catalog-from-sources.sh

on Minikube

./build/scripts/minikube-tests/test-operator-from-sources.sh

2. Create a custom runtime class:

kind: RuntimeClass
apiVersion: node.k8s.io/v1
metadata:
  name: my-custom-runtime
handler: runc

3. Start a workspace and verify that the workspace pod does not have spec.runtimeClassName field.
4. Stop the workspace
5. In the CheCluster CR, set spec.devEnvironments.runtimeClassName field to my-custom-runtime
6. Start the workspace from step 4.
7. Verify that the workspace pod has the spec.runtimeClassName filed set to my-custom-runtime

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• Development resource are up to date
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[dkwon17]

I've set the type to *string because that is the type for RuntimeClassName in PodSpec struct:

https://github.com/kubernetes/api/blob/9dc1a952bda9aeb400aa6409b7d89eff50d6ea77/core/v1/types.go#L3920

[tolusha]

Maybe PodRuntimeClassName ?

[dkwon17]

IMHO I don't know if it's necessary since we have names such as:

che-operator/api/v2/checluster_types.go

Lines 95 to 100 in 813dcbf

	// The node selector limits the nodes that can run the workspace pods.
	// +optional
	NodeSelector map[string]string `json:"nodeSelector,omitempty"`
	// The pod tolerations of the workspace pods limit where the workspace pods can run.
	// +optional
	Tolerations []corev1.Toleration `json:"tolerations,omitempty"`

[openshift-ci]

@dkwon17: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v14-che-behind-proxy	813dcbf	link	true	/test v14-che-behind-proxy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dkwon17, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[devstudio-release]

Build 3.17 :: operator_3.x/401: Console, Changes, Git Data

[devstudio-release]

Build 3.17 :: sync-to-downstream_3.x/7719: Console, Changes, Git Data

[devstudio-release]

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7711: Console, Changes, Git Data

[devstudio-release]

Build 3.17 :: push-latest-container-to-quay_3.x/4932: Console, Changes, Git Data

[devstudio-release]

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7711:

devspaces-operator : 3.x :: Build 64352253 : quay.io/devspaces/devspaces-rhel8-operator:3.17-13
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/4932 triggered

[devstudio-release]

Build 3.17 :: operator_3.x/401:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7719 triggered

[devstudio-release]

Build 3.17 :: update-digests_3.x/7580: Console, Changes, Git Data

[devstudio-release]

Build 3.17 :: operator-bundle_3.x/3617: Console, Changes, Git Data

[devstudio-release]

Build 3.17 :: sync-to-downstream_3.x/7720: Console, Changes, Git Data

[devstudio-release]

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7712: Console, Changes, Git Data

[devstudio-release]

Build 3.17 :: push-latest-container-to-quay_3.x/4933: Console, Changes, Git Data

[devstudio-release]

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7712:

devspaces-operator-bundle : 3.x :: Build 64354327 : quay.io/devspaces/devspaces-operator-bundle:3.17-14
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/4933 triggered;

Bundle CSV related images:
- quay.io/devspaces/code-rhel8:3.17-11
- quay.io/devspaces/configbump-rhel8:3.17-2
- quay.io/devspaces/dashboard-rhel8:3.17-10
- quay.io/devspaces/devspaces-rhel8-operator:3.17-13
- quay.io/devspaces/idea-rhel8:3.17-1
- quay.io/devspaces/pluginregistry-rhel8:3.17-6
- quay.io/devspaces/server-rhel8:3.17-4
- quay.io/devspaces/traefik-rhel8:3.17-2
- quay.io/devspaces/udi-rhel8:3.17-2
= registry.redhat.io/devspaces/udi-rhel8:3.15-5.1724033655
= registry.redhat.io/openshift4/ose-kube-rbac-proxy:v4.14.0-202408260910.p0.g1a646b9.assembly.stream.el8
= registry.redhat.io/openshift4/ose-oauth-proxy:v4.14.0-202408260910.p0.ga4a2f27.assembly.stream.el8
= registry.redhat.io/rhscl/mongodb-36-rhel7:1-50
= registry.redhat.io/ubi8/ubi-minimal:8.8-1072.1697626218

[devstudio-release]

Build 3.17 :: sync-to-downstream_3.x/7720:

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/7712 triggered; /job/DS_CI/job/dsc_3.x triggered;

[devstudio-release]

Build 3.17 :: operator-bundle_3.x/3617:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7720 triggered

[devstudio-release]

Build 3.17 :: copyIIBsToQuay/2796: Console, Changes, Git Data

[devstudio-release]

Build 3.17 :: dsc_3.x/2003: Console, Changes, Git Data

[devstudio-release]

Build 3.17 :: update-digests_3.x/7580:

Detected new images: rebuild operator-bundle
* devspaces-operator; /DS_CI/operator-bundle_3.x/3617 triggered

[devstudio-release]

Build 3.17 :: dsc_3.x/2003:

3.17.0-CI