Log a warning for slow signal updates to subscribers #116
Conversation
Performed by scripts/prepare_release.sh 0.6.0-dev.0 This is to make sure that if someone builds from source it should be clearly visible that they are not using the official 0.5.0 version.
See https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes Was newly introduced Also introducing a weekly cron to detect this type of regressions
| @@ -1203,7 +1203,7 @@ impl<'a, 'b> DatabaseReadAccess<'a, 'b> { | |||
| } | |||
| } | |||
|
|
|||
| impl<'a, 'b> DatabaseWriteAccess<'a, 'b> { | |||
| impl DatabaseWriteAccess<'_, '_> { | |||
There was a problem hiding this comment.
Why did you changed from explicit lifetimes to anonymous lifetimes? did it complain?
There was a problem hiding this comment.
This is inherited from #114, see also https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
As we use "latest and greatest" clippy we get these types of regressions now and then
(long term we could discuss if we rather should have a fixed rust/clippy/fmt version and perform updates only when preparing for a (major) release, to reduce the risk of regressions)
| @@ -13,7 +13,7 @@ | |||
|
|
|||
| [package] | |||
| name = "databroker-cli" | |||
| version = "0.5.0" | |||
| version = "0.5.0-dev.1" | |||
There was a problem hiding this comment.
It would be better with "0.5.1-dev.1" (or "0.5.1-dev.0") as it is not a pre-release to 0.5.0 but rather a possible pre-release to an upcoming 0.5.1
https://github.com/eclipse-kuksa/kuksa-databroker/wiki/Release-Process#proposed-versioning-scheme
When subscribers are too slow to process vehicle signal updates, databroker will log a warning.