Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cargo check for all features #121

Merged
merged 3 commits into from
Jan 2, 2025
Merged

Add cargo check for all features #121

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a27c702
add cargo-hack
AkhilTThomas Dec 13, 2024
6c1eab6
fix missing feature gate in databroker-cli
AkhilTThomas Dec 13, 2024
c344974
move cargo check each feat to unit test action
AkhilTThomas Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/kuksa_databroker_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,9 @@ jobs:
# Needed for pip
with:
python-version: '3.12'
- uses: taiki-e/[email protected]
with:
tool: [email protected]
- name: Install build prerequisites
working-directory: ${{github.workspace}}/
run: |
Expand All @@ -173,6 +176,10 @@ jobs:
run: |
./scripts/build-databroker.sh ${{ matrix.platform.name }}

- name: "Check each feature"
working-directory: ${{github.workspace}}
run: cargo hack check --each-feature
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we run this for each platform in the build matrix, but I think we do nothing platform specific here, so maybe moving it out can save some time?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in the (unit) test job?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SebastianSchildt This adds ~5m 12s runtime for the unit test action.


- name: "Archiving artifacts"
shell: bash
working-directory: ${{github.workspace}}/dist/${{ matrix.platform.name }}
Expand Down
1 change: 1 addition & 0 deletions databroker-cli/src/cli.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ pub struct Cli {
}

impl Cli {
#[cfg(feature = "tls")]
pub fn get_ca_cert(&mut self) -> Option<String> {
self.ca_cert.clone()
}
Expand Down
Loading