Improved throughput: reduce unnecessary overload on gRPC bidirectional stream by avoiding empty responses #99
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/databroker-api-v2 #99 +/- ##
=============================================================
- Coverage 59.36% 59.27% -0.10%
=============================================================
Files 33 33
Lines 16005 16026 +21
=============================================================
- Hits 9502 9499 -3
- Misses 6503 6527 +24 ☔ View full report in Codecov by Sentry. |
rafaeling
changed the title
| if let Err(err) = response_stream_sender.send(Ok(response)).await | ||
| { | ||
| debug!("Failed to send response: {}", err); | ||
| if let Some(value) = response { |
There was a problem hiding this comment.
We should better clarify in proto files when response shall be sent. Today my interpretation of the text below is that you ALWAYS should get a Response message. We should better clarify with something like "Databroker returns PublishValuesResponse upon error, and nothing upon success"
Current text:
Provider sends PublishValuesRequest -> Databroker returns PublishValuesResponse
Similar for other similar cases
|
I close this one and create a new one, branched off the wrong branch. #100 |
Databroker was underperforming compared to
sdv.databroker.v1APIs implementation.gRPC bidirectional stream buffer was being overloaded due to the unnecessary return of empty responses, which caused reduced throughput and buffer congestion.