Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Actuate all three motors of the seat #114

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

lukasmittag
Copy link
Contributor

@lukasmittag lukasmittag commented Nov 21, 2023

!!!! DO NOT MERGE !!!!

Motor1 = Position = backwards/forwards = ECU2 motor1
Motor2 = Tilt = tilt back/forth = ECU2 motor3
Motor3 = Height = upwards/downwards = ECU1 motor1

PositionSubscriber for every VSS Datapoint in own thread.
Seat controller waits for one posititon to be target position and then continues with the next one.
Cansim implemented for all three motors (not the actual behavior because direction is switched for some reason)
Tests and scripts to move manually (e.g. seat service cli) not yet adapted. They only test/wok for position changes.

@lukasmittag lukasmittag marked this pull request as ready for review November 21, 2023 14:26
@lukasmittag lukasmittag reopened this Nov 21, 2023
@lukasmittag lukasmittag changed the title Change ECU1 to ECU2 to address seat forward backward motor Actuate all three motors of the seat Dec 12, 2023
@erikbosch
Copy link
Contributor

What is the plans for this one? If we intend to merge it here and can possibly "cherry-pick" it to the migrated items in https://github.com/eclipse-kuksa/kuksa-incubation afterward

@boschglobal boschglobal closed this by deleting the head repository Mar 21, 2024
@erikbosch
Copy link
Contributor

Reopening all PRs closed by accident by boschglobal maintenance

@erikbosch erikbosch reopened this Mar 21, 2024
@SebastianSchildt
Copy link
Contributor

Hi @lukasmittag can/will you move this PR to the new home of seat service in incubation? I still think we want this, but then we could close this one

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants