This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 17
Actuate all three motors of the seat #114
Open
lukasmittag
wants to merge
28
commits into
eclipse-kuksa:main
Choose a base branch
from
boschglobal:MuHackathon/seat_service_forward_backward
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Actuate all three motors of the seat #114
lukasmittag
wants to merge
28
commits into
eclipse-kuksa:main
from
boschglobal:MuHackathon/seat_service_forward_backward
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasmittag
changed the title
Change ECU1 to ECU2 to address seat forward backward motor
Actuate all three motors of the seat
Dec 12, 2023
DEC and INC are changed within real seat example
What is the plans for this one? If we intend to merge it here and can possibly "cherry-pick" it to the migrated items in https://github.com/eclipse-kuksa/kuksa-incubation afterward |
Reopening all PRs closed by accident by boschglobal maintenance |
Hi @lukasmittag can/will you move this PR to the new home of seat service in incubation? I still think we want this, but then we could close this one |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!!!! DO NOT MERGE !!!!
Motor1 = Position = backwards/forwards = ECU2 motor1
Motor2 = Tilt = tilt back/forth = ECU2 motor3
Motor3 = Height = upwards/downwards = ECU1 motor1
PositionSubscriber for every VSS Datapoint in own thread.
Seat controller waits for one posititon to be target position and then continues with the next one.
Cansim implemented for all three motors (not the actual behavior because direction is switched for some reason)
Tests and scripts to move manually (e.g. seat service cli) not yet adapted. They only test/wok for position changes.