Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add trailing semicolon in generated ast interfaces #1345

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Add trailing semicolon in generated ast interfaces #1345

merged 2 commits into from
Jan 17, 2024

Conversation

gfontorbe
Copy link
Contributor

@gfontorbe gfontorbe commented Jan 17, 2024 •
edited
Loading

Closes #1332

Add a semicolon after interfaces properties for consistency in generated ast.ts.
Also updated relevant test files and generated ast files in examples and Langium grammar.

@msujew msujew added cli CLI related issue ast AST structure related issue labels Jan 17, 2024
spoenemann
spoenemann approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gfontorbe gfontorbe merged commit 067f9b6 into main Jan 17, 2024
5 checks passed
@gfontorbe gfontorbe deleted the gfontorbe/trailing-semicolon-ast branch January 17, 2024 11:13
@msujew msujew added this to the v3.0.0 milestone Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spoenemann spoenemann spoenemann approved these changes

Assignees
No one assigned
Labels
ast AST structure related issue cli CLI related issue
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

Trailing ';' in generated/ast.ts are inconsistent
3 participants
@gfontorbe @spoenemann @msujew