Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1230
Even though I expected this to be a small fix, this was surprisingly complicated. The main issue is that we don't get notified what is contained in the directory that has changed. Therefore, we need to "manually" dig through the changed directory. Performs a few changes:
UriTrie
data structure. It's a tree structure for document storage that respects directories (compared to the previous flat map). It is required to quickly figure out which documents belong to a changed/deleted directory.VirtualFileSystemProvider
that can be programmed for specific tests.The behavior is tested by some integration tests, and can be manually tested by deleting/renaming directories with DSL files within them. The old documents should be correctly deleted and the documents from the renamed directory should've been correctly added to the documents service.