[BREAKING] Device Factory enhancements #297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Invalid characters are now replaced by an underscore (_) instead of a hyphen (-). This matches the Java identifier format used in EMF. * By default, all Java identifier characters are now allowed. This means that the name of a model, provider, service or resource can use locale characters (greek letters, accents, ...). * A new boolean mapping option is available: "names.ascii". If true, the only characters allowed in names are ASCII letters and digits, and the underscore. The names are first normalized in NFKD form to remove diacritics, then all unexpected characters are replaced by an underscore. * In both modes, ASCII or Java identifiers: if the name is a reserved Java keyword or starts with digit, then it is prefixed with an underscore. Tests have been added to check the new behaviours.
If "model.raw" is set to true, then the model string is not sanitized. This allows to give existing URLs as models instead of simple names.
|
Closed as not necessary since #324 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides two changes decided after discussions with @juergen-albert about a better integration of the Device Factory with EMF:
_) instead of a hyphen (-)names.asciiCharacter.isJavaIdentifierPart) or underscoresmodel.rawmapping option, that disables the normalization of the@modelcontent. This allows to use URLs as models.Note: this is currently a draft PR, the documentation has to be updated