SensorThings MQTT: Queue notifications to keep their order #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcalmant
force-pushed
the
thomas/mqtt-fix
branch
from
eb56584 to
17874e2
Compare
Integration tests were failing because sensiNact notifications and their handling were done in (at least) 2 threads, meaning that the order of sending of notification couldn't be guaranteed. This commit uses a single thread that handles the publication of messages in the same order as the notifications, still using multiple threads to handle notifications and payload generation.
tcalmant
force-pushed
the
thomas/mqtt-fix
branch
from
17874e2 to
8c06435
Compare
timothyjward
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration tests were failing because sensiNact notifications and their handling were done in (at least) 2 threads, meaning that the order of sending of notification couldn't be guaranteed.
This commit uses a single thread that handles the publication of messages in the same order as the notifications, still using multiple threads to handle notifications and payload generation.
This should fix the CI test failures of the SensorThings MQTT project