Load plugin readme from file system #14699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
force-pushed
the
msujew/local-plugin-readme
branch
from
49cfcad to
0d6642d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #13595
Ensures that we attempt to load the readme content from the file system, if it is available. Since the capitalization is not guaranteed, the code will attempt to find all possible versions of
readme.md/readme.If the readme is not available locally, it will still attempt to load the readme from the remote URL.
How to test
Follow the steps from #13595. Ensure that the readme file of the plugin is shown.
Review checklist
Reminder for reviewers